From 2273d20160f5d9bc529a1ba7b3986698459e58ab Mon Sep 17 00:00:00 2001 From: gramps Date: Wed, 21 Oct 2026 19:46:25 -0700 Subject: [PATCH] TASK 58: the properties panel wears the theme (no more light-system chrome) The creator asked why the Stream Alerts "Display" drop-down was not in the same style as the other drop-downs. It was never given the theme's YtComboBox style - only a hand-painted Background/Foreground. Setting colours changes the paint, not the template, so WPF still drew the light system ComboBox (grey border, system arrow, white popup list) on top of the dark panel. The chat Font drop-down was a copy of the same mistake, and every check box was the light system one. The sweep of the whole properties panel (then the app): - ComboBox x2 (chat Font, alert Display) -> YtComboBox, hand-painted colours gone - TextBox x16 in the properties panel -> YtTextBoxCompact (new, BasedOn YtTextBox: 11px / padding 4,2 - the panel is dense, the full 13px box would double it) - CheckBox x2 (chat) + x3 (preview broadcast) + x1 (socials dialog) -> YtCheckBox (new: a 14x14 rounded box + tick path, accent fill when checked) - the layer-rename field -> YtTextBoxCompact via BasedOn, still borderless - buttons, pills, sliders: already themed, untouched The sweep also killed a typo'd foreground (#e0d0e0 for #e0e0e0) and the only remaining hand-painted colour is the deliberate dimming of the two read-only path fields. Guard: ytLive.Tests/PropertiesStyleTests.cs (the ONE Good Dog test) parses the app XAML and fails if an unstyled drop-down, check box or properties field comes back. 431/431 green, 0 warnings. --- Controls/LeftPanel.xaml | 63 ++++++-------- Controls/PreviewPane.xaml | 12 +-- Controls/index.md | 2 +- HANDOFF.md | 12 ++- MyMistakes.md | 22 +++++ SocialsDialog.xaml | 2 +- TASKS.md | 1 + TASKS/task-58-properties-style-consistency.md | 45 ++++++++++ Themes/Controls.xaml | 59 +++++++++++++ Themes/index.md | 9 +- ai.md | 2 +- ytLive.Tests/PropertiesStyleTests.cs | 84 +++++++++++++++++++ 12 files changed, 262 insertions(+), 51 deletions(-) create mode 100644 TASKS/task-58-properties-style-consistency.md create mode 100644 ytLive.Tests/PropertiesStyleTests.cs diff --git a/Controls/LeftPanel.xaml b/Controls/LeftPanel.xaml index c4047d9..2019db4 100644 --- a/Controls/LeftPanel.xaml +++ b/Controls/LeftPanel.xaml @@ -155,12 +155,11 @@ - + + + + + +