gramps/LlamaCasty
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(ui): alert rows are two lines of text — the heading line was redundant

Browse Source 
Creator: system messages are limited to two lines; the label above the message ('STEAM ID NOT
PRESENT', 'STREAM') was repeating what the row already said and pushing the stack past its budget.

AttentionAlert loses Label; rows render Text only. The licence row is now exactly:
    Steam ID Limit: 30fps
    Click for More Info
(60fps with a close control once owned). Rows are identified by Id internally, so nothing in the UI
depends on the removed text. Tests updated to assert position/text rather than the heading.
This commit is contained in:
gramps
2026-11-05 12:13:45 -08:00
parent 72cb3ad55a
commit 3fde7fcfe6
7 changed files with 25 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ViewModels/MainViewModel.Alerts.cs
+4 -7
View File
@@ -46,8 +46,6 @@ public partial class MainViewModel
return $"Steam ID Limit: {entitled}fps\nClick for More Info";
}
private string SteamLicenceLabel() => IsAppOwned ? "STEAM ID PRESENT" : "STEAM ID NOT PRESENT";
/// <summary>Recomputes row 1 in place. Called at startup and whenever ownership changes.</summary>
private void RefreshSteamLicenceAlert()
{
@@ -63,7 +61,6 @@ public partial class MainViewModel
var alert = new AttentionAlert(
SteamLicenceAlertId,
SteamLicenceLabel(),
SteamLicenceText(),
IsPinned: !IsAppOwned,
AttentionAlertAction.About);
@@ -76,9 +73,9 @@ public partial class MainViewModel
/// <summary>Pushes an event alert. Newest sits directly under the licence indicator; older ones
/// stack beneath, so the newest is the one nearest the eye.</summary>
private AttentionAlert? PushAttentionAlert(string id, string label, string text, long logFrom, long logTo)
private AttentionAlert? PushAttentionAlert(string id, string text, long logFrom, long logTo)
{
var alert = new AttentionAlert(id, label, text, IsPinned: false, AttentionAlertAction.Logs, logFrom, logTo);
var alert = new AttentionAlert(id, text, IsPinned: false, AttentionAlertAction.Logs, logFrom, logTo);
var insertAt = _attentionAlerts.Count(alert => alert.Id == SteamLicenceAlertId);
var existing = _attentionAlerts.FirstOrDefault(candidate => candidate.Id == id);
if (existing != null)
@@ -95,8 +92,8 @@ public partial class MainViewModel
}
/// <summary>Test seam: pushes an event row without a stream session behind it.</summary>
internal AttentionAlert? PushAttentionAlertForTest(string id, string label, string text, long logFrom, long logTo)
=> PushAttentionAlert(id, label, text, logFrom, logTo);
internal AttentionAlert? PushAttentionAlertForTest(string id, string text, long logFrom, long logTo)
=> PushAttentionAlert(id, text, logFrom, logTo);
private void RemoveAttentionAlert(string id)
{