fix(media): play at the clip's real rate — the pipe was copying a frame per read
Reported as "the default video and the green screen video are playing at a hideously slow rate… I thought the playback timing issues were resolved?!" They were not: two independent faults, both in the shared clip pipe. 1. QUADRATIC COPY IN THE FRAME READER. `RawVideoFrameReader` re-concatenated the whole pending buffer on every `Feed`, and the pipe feeds it 64 KB at a time. A 1080p BGRA frame is 8 MB, so one frame cost ~127 copies of a growing buffer — roughly half a gigabyte of memcpy per frame. Measured on a 30 fps clip: 6 frames in 3 seconds (2 fps). The reader now fills one preallocated frame buffer and hands that array to the VideoFrame, so a frame is copied exactly once. Pipe reads are 256 KB. Same clip: 29 fps. 2. PACING SLEPT ON TOP OF THE WORK. A fixed 1/fps sleep after each frame adds the frame's own cost, so 20 ms of work on a 30 fps clip yields 1/(33+20) ≈ 19 fps — measured 20.9. Pacing is now deadline-based (`Helpers/FramePacer.cs`): wait only what is left of the frame's interval, resync when a frame overruns instead of bursting, never sleep longer than one interval. The alert clip shares this pipe, so it gained both fixes. Tests: `FramePacerTests` (subtract work, no drift, late → resync, zero duration, reset); `ChromaKeyRealClipTests.RealClip_PlaysAtItsNativeRate` (throughput floor of 15 fps on the real 30 fps clip — the old code sat at 2); the two pacing assertions now check "at most one interval" rather than an exact sleep, which is what deadline pacing means. Full suite: 574 passed, 0 failed, clean build.
This commit is contained in:
@@ -71,6 +71,35 @@ public class ChromaKeyRealClipTests
|
||||
Assert.True(ratio < 1.0, "everything vanished; the subject should survive the key");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Throughput guard (2026-11-05): the pipe used to copy a growing pending buffer on every 64 KB
|
||||
/// read, so a 1080p frame cost ~0.5 GB of copying and playback pinned at ~2 fps whatever the
|
||||
/// pacing said. A 30 fps clip must here deliver at least 15 fps (measured 29 in a Debug build) —
|
||||
/// a floor wide enough for slow hardware and far above the 2 fps regression.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task RealClip_PlaysAtItsNativeRate()
|
||||
{
|
||||
Assert.True(File.Exists(ClipPath), $"missing fixture: {ClipPath}");
|
||||
|
||||
var locator = new FixedLocator(FfmpegPath);
|
||||
var probe = new FfmpegFrameRateProbe(locator, () => new FfmpegDecodeProcess());
|
||||
var frames = 0;
|
||||
using var pipe = new VideoClipPipe(
|
||||
ClipPath, 1920, 1080, locator, () => new FfmpegDecodeProcess(),
|
||||
frameRateProbe: probe, audio: false);
|
||||
pipe.FrameAvailable += _ => Interlocked.Increment(ref frames);
|
||||
|
||||
var clock = System.Diagnostics.Stopwatch.StartNew();
|
||||
await pipe.StartAsync();
|
||||
await Task.Delay(2000);
|
||||
await pipe.StopAsync();
|
||||
clock.Stop();
|
||||
|
||||
var fps = frames / clock.Elapsed.TotalSeconds;
|
||||
Assert.True(fps >= 15, $"playback ran at {fps:0.0} fps — frames are being lost in the pipe again");
|
||||
}
|
||||
|
||||
private static (int R, int G, int B) ParseHex(string hex)
|
||||
{
|
||||
var value = hex.TrimStart('#');
|
||||
|
||||
Reference in New Issue
Block a user