gramps/LlamaCasty
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: refresh HANDOFF — refactor Commits 3-5 landed

Browse Source
This commit is contained in:
Llama Chile Shop
2026-08-30 07:36:12 -07:00
parent e2867198b9
commit 58e7b3f3d1
1 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HANDOFF.md
+25 -8
View File
@@ -6,11 +6,27 @@
No feature branches pre-1.0: all work lands on `main` per work unit. No feature branches pre-1.0: all work lands on `main` per work unit.
**Latest commit:** `6031a56` — gear cleanup + Default Location for Recordings + single Start + socials hover glow. **Latest commit:** `e286719` — Commit 5/12 of the MainViewModel refactor (Webcam partial, tag `refactor-commit-5`).
## What's In Flight ## What's In Flight
Nothing — clean tree, ready for next task. **MainViewModel partial split (Phase 1):** 5 of 12 refactor commits landed and pushed.
Tags `refactor-commit-0…5` = scaffold, Account, License, Scenes, Background, Webcam.
Latest head `e286719`. Working tree clean.
Remaining partials in order: `Audio` (Commit 6), `Trax` (7), `Socials` (8), `Streaming` (9),
`Chat` (10), `Overlays` (11). Each lands the same way: cut → build 0 warnings →
`./scripts/verify.sh` + `./scripts/scope-check.sh "file1" …` → commit titled
`refactor: split <Area> out of MainViewModel — Commit N/12 (tag refactor-commit-N)`
with the `ViewModels/index.md` progress update in the SAME commit → `git tag refactor-commit-N`
→ `git push && git push --tags`.
Known partial-usings list (grep-verified):
`Scenes` = ObjectModel+Specialized+ComponentModel+`ytLive`+Models+Services;
`Background` = ObjectModel+IO+Windows+Input+Media+Media.Imaging+Helpers+Models+Services;
`Webcam` = Windows+Input+Media.Imaging+`ytLive`+Models+Services.
`INotificationService.Info/Warning/Error/Success` are default interface methods → any
partial calling `_notifications.X` needs `using ytLive.Services;`.
## Landmines ## Landmines
@@ -35,11 +51,12 @@ Nothing — clean tree, ready for next task.
- TASK 22 (Audio sync offset): not started — required for v1. - TASK 22 (Audio sync offset): not started — required for v1.
- TASK 30: gear cleanup + record location + single Start + preview layout restructure — shipped across commits `6031a56` + `61b850f` + `455a409`. - TASK 30: gear cleanup + record location + single Start + preview layout restructure — shipped across commits `6031a56` + `61b850f` + `455a409`.
- Monetization: deferred (creator rethinking price/subscription model). - Monetization: deferred (creator rethinking price/subscription model).
- **File refactor (in progress — Commit 0 done):** MainViewModel.cs (3,900 lines) will be split into functional partials (Scenes, Background, Webcam, Audio, Trax, Socials, Streaming, Chat, Overlays, Account, License). `MainViewModel` is now `public partial class` (scaffold commit). Remaining: one commit per partial, each a roll-back point, `verify.sh` + `scope-check.sh` before each, docs in the same commit. MainWindow.xaml (1,681 lines) will be split into UserControls after Phase 1. Zero behavior change, tests stay green. - **File refactor (in progress — Commit 5/12 done):** MainViewModel.cs (3,900 lines) split into functional partials (Scenes, Background, Webcam ✔; Audio, Trax, Socials, Streaming, Chat, Overlays pending; Account, License ✔). One commit per partial, each a roll-back point (`refactor-commit-N` tags), `verify.sh` + `scope-check.sh` before each, docs in the same commit. MainWindow.xaml (1,681 lines) will be split into UserControls after Phase 1. Zero behavior change, tests stay green.
- Monitoring: partials must re-declare their own `using`s — core file's usings do NOT carry across partial files. Field-initializer order across parts is compiler-ordered but no moved field has interdependent initializers.
## Session summary (2026-08-29) ## Session summary (2026-08-30)
- Corrected task status tracking: TASK 4 → ✅ Done, TASK 3 item15 (Window capture) → ✅ absorbed into Screen picker, TASK 3 status updated to 27/30 - Completed refactor Commits 3/12 (Scenes, `dcdfcb9`), 4/12 (Background, `db068ab`), 5/12 (Webcam, `e286719`) — each tagged `refactor-commit-N`, pushed with `--tags`, verified (0-warning clean build, only the 2 known test failures).
- ai.md updated: TASK 4 steps 5-7 added as shipped, stale "frame-pipeline wiring follows" removed - Background partial took the full bucket: background model, screen capture machinery, display picker, preview fns, capture commands. Webcam partial took identity + per-scene configs + capture callbacks + size safeguards.
- HANDOFF.md todo state expanded with full statuses for all active tasks - Mea culpa: asked the user a bucket-boundary question that the rules already answered — won't repeat; buckets are fixed.
- Discussed file organization: MainViewModel.cs (3,900 lines) is a god-object with 49 commands mixing scenes, camera, audio, streaming, socials, overlays, and auth. Next session: split into functional partials - Test-suite note: full `vstest` run aborted early once (236/237) with only the 2 known failures — accepted by `verify.sh` as a known flake.