gramps/LlamaCasty
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: URI text box no longer shows under webcam source

Browse Source 
The web source section's visibility was bound to SelectedElement.Type
via a converter, but WebcamSceneConfig has no Type property — the WPF
binding path didn't resolve correctly and the section leaked through.

Added IsWebSource virtual property to SceneElement (mirrors existing
IsWebcam pattern), overridden in Source to return
Type == SourceType.WebSource. Section visibility now binds directly to
SelectedElement.IsWebSource via BoolToVis.

1c of 7-issue polish batch. 207 tests, 0 warnings.
This commit is contained in:
Llama Chile Shop
2026-08-18 07:42:29 -07:00
parent f51f6a0a1a
commit 6e446cb7ad
4 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TASKS.md
+1 -1
View File
@@ -827,7 +827,7 @@ No changes to `MusicPlayer`, the 0.20 cap, the ducker, or the meter zones. Build
10. ✅ Web source — `SourceType.WebSource`, pick list (all scenes), URI text input
11. ✅ Elements scrollbar deselect fix — clicking the Elements panel scrollbar no longer deselects the selected element (scrollbar lives inside the ScrollViewer, not the StackPanel; guard now checks `ElementsScrollViewer` instead of `ElementsPanel`)
12. ✅ Web source URI + buttons inline — merged URI TextBox and check/revert buttons into a single DockPanel row (✓ rightmost, ✕ left); buttons no longer wrap to a separate line
13. ✅ Web source URI hidden for webcam (verified) — `SourceTypeToVisibilityConverter` returns Collapsed when `SelectedElement.Type` is null (WebcamSceneConfig has no `Type` property); URI section correctly hidden
13. ✅ Web source URI hidden for webcam — URI section was showing for webcam due to WPF binding path `SelectedElement.Type` not resolving on `WebcamSceneConfig`; replaced with `IsWebSource` virtual property on `SceneElement` (mirrors existing `IsWebcam` pattern), overridden in `Source` to return `Type == SourceType.WebSource`, bound via `BoolToVis`
---