Web source: render at canvas size 1920x1080 — full-bleed widgets no longer truncated to upper-left
This commit is contained in:
+20
-19
@@ -6,32 +6,33 @@
|
|||||||
working). **NOT pushed — user rule: never push without explicit instruction (2026-08-24).** No feature
|
working). **NOT pushed — user rule: never push without explicit instruction (2026-08-24).** No feature
|
||||||
branches pre-1.0: all work lands on `main` per work unit.
|
branches pre-1.0: all work lands on `main` per work unit.
|
||||||
|
|
||||||
## The web-source rendering work (2026-08-28) — CURRENT MODEL: stable viewport + content-bounds crop
|
## The web-source rendering work (2026-08-28) — CURRENT MODEL: canvas-size viewport + content crop
|
||||||
|
|
||||||
**Background:** viewport==box made dragging the box reflow the page (truncation, scrollbars,
|
**Root cause finally isolated:** hosting the page at the ELEMENT-box size clips full-bleed widgets
|
||||||
unrecoverable image, "janky at stressful geometries"). Fixed-viewport + `Uniform` left letterbox
|
(designed for ~1920×1080) to their upper-left chunk inside a small viewport — "image truncated to
|
||||||
dead space. CSS reset enlarged the gap. Scrollbars were called "super fail". The right/bottom
|
the upper-left corner regardless of scaling." That truncation persisted across every earlier
|
||||||
dead-space + "not anchored at (0,0)" report persisted across every model — dead space was
|
model because all of them rendered the page at the box (or a mix); e917c41's full 1920×1080
|
||||||
page-internal (widget content smaller than the viewport), which is now cropped out.
|
render was the only one that showed full content, and its letterbox dead space was purely the
|
||||||
|
display `Uniform` + the box aspect mismatch — not the render.
|
||||||
|
|
||||||
**The model that satisfies invariants (implemented, visual verification pending):**
|
**The model (implemented, visual verification pending):**
|
||||||
- `Services/WebView2Manager.cs` — stable viewport = the element's size at `Register` (snapshot,
|
- `Services/WebView2Manager.cs` — page renders at the MASTER CANVAS size (1920×1080), stable,
|
||||||
never tracked → no reflow/truncation during resize). `overflow:hidden` (html+body) +
|
never tracked: full-bleed widgets render FULL (no upper-left truncation); dragging the box never
|
||||||
transparent-bg injection on every nav (nothing else). After each navigation,
|
reflows the page; `overflow:hidden` (html+body) + transparent-bg injection. After each nav
|
||||||
`QueryContentBoundsAsync` reads the page's real content rect
|
`QueryContentBoundsAsync` reads the page's real content rect
|
||||||
(`scrollWidth/scrollHeight` vs `innerWidth/innerHeight` via `ExecuteScriptAsync` + JSON) and
|
(`scrollWidth/scrollHeight` vs `innerWidth/innerHeight`) and `CaptureFrame` **crops to the
|
||||||
`CaptureFrame` **crops the capture to the actual content bounds, anchored at (0,0)** — dead
|
actual content bounds anchored at (0,0)**. Immediate capture on `NavigationCompleted`.
|
||||||
space inside the viewport no longer reaches the box. Immediate capture on `NavigationCompleted`.
|
- `MainWindow.xaml` — web `<Image>` `Stretch="Fill"`: the cropped 1920×1080 frame maps flush under
|
||||||
- `MainWindow.xaml` — web `<Image>` uses `Stretch="Fill"`: the cropped frame maps edge-to-edge,
|
the box (Box == widget bounds at every size, pinned (0,0), no dead space).
|
||||||
so the selection box always bounds the real widget. `FramePump` unchanged.
|
- Invariants: **render at canvas size; crop to content; Fill to box.**
|
||||||
- Invariants: **page viewport stable; display Fill-crops to content and fills the box.**
|
|
||||||
|
|
||||||
**Property panel / sliders (2026-08-28):** web URI ✕ clears the textbox; web ✓/✕ icon buttons
|
**Property panel / sliders (2026-08-28):** web URI ✕ clears the textbox; web ✓/✕ icon buttons
|
||||||
`IsTabStop="False"` so Tab walks X→Y→W→H→URI; Slider style `IsMoveToPointEnabled="True"`
|
`IsTabStop="False"` so Tab walks X→Y→W→H→URI; Slider style `IsMoveToPointEnabled="True"`
|
||||||
restores click-anywhere-on-bar.
|
restores click-anywhere-on-bar. All three confirmed fixed by the creator.
|
||||||
|
|
||||||
Build: 0 warnings; tests 4/4. Rejected for the record: fixed 1920×1080+`Uniform` (letterbox),
|
Build: 0 warnings; tests 4/4. Rejected for the record: box-sized viewport (upper-left truncation),
|
||||||
CSS margin/100% reset (enlarged gap), viewport==box (reflow/truncation/scrollbars).
|
fixed 1920×1080 + `Uniform` (letterbox dead space), CSS margin/100% reset (enlarged gap),
|
||||||
|
viewport==box (reflow/truncation/scrollbars).
|
||||||
|
|
||||||
## Key facts / landmines
|
## Key facts / landmines
|
||||||
|
|
||||||
|
|||||||
@@ -45,16 +45,16 @@ public sealed class WebView2Manager : IDisposable
|
|||||||
{
|
{
|
||||||
if (_sessions.ContainsKey(source.Id)) return;
|
if (_sessions.ContainsKey(source.Id)) return;
|
||||||
|
|
||||||
// OBS model: the page renders ONCE at a stable viewport — the size the
|
// OBS model: the page renders at the MASTER CANVAS size (1920×1080),
|
||||||
// element was created at (snapshot, never tracked, so dragging the box
|
// stable, never tracked. Full-bleed widgets (designed for the canvas)
|
||||||
// never reflows/truncates the page and no scrollbars appear). The
|
// render fully instead of being clipped to a small box-sized viewport;
|
||||||
// captured texture is then stretched by the display (Stretch=Fill) into
|
// dragging the box never reflows the page. The capture is cropped to
|
||||||
// whatever box the user draws, so the frame always bounds content with
|
// the widget's actual content bounds (QueryContentBoundsAsync) and the
|
||||||
// zero dead space. Geometry-agnostic: any widget, any box.
|
// display (Stretch=Fill) maps it flush under the box, anchored at (0,0).
|
||||||
var webView = new WebView2
|
var webView = new WebView2
|
||||||
{
|
{
|
||||||
Width = Math.Max(1, source.Width),
|
Width = 1920,
|
||||||
Height = Math.Max(1, source.Height),
|
Height = 1080,
|
||||||
DefaultBackgroundColor = System.Drawing.Color.Transparent,
|
DefaultBackgroundColor = System.Drawing.Color.Transparent,
|
||||||
Visibility = System.Windows.Visibility.Visible,
|
Visibility = System.Windows.Visibility.Visible,
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -917,17 +917,16 @@ capturing the primary display (which causes the infinity mirror effect).
|
|||||||
8. ✅ Preview shows live web content (not just a blank rectangle)
|
8. ✅ Preview shows live web content (not just a blank rectangle)
|
||||||
9. ☐ Handle navigation errors, invalid URIs, timeout gracefully
|
9. ☐ Handle navigation errors, invalid URIs, timeout gracefully
|
||||||
|
|
||||||
**Rendering model (2026-08-28, stable viewport + content-bounds crop):**
|
**Rendering model (2026-08-28, canvas-size viewport + content-bounds crop):**
|
||||||
the page renders ONCE at the size the element was created at (snapshot in `Register`, never
|
the page renders at the MASTER CANVAS size (1920×1080), stable, never tracked. Two earlier bugs
|
||||||
tracked) — dragging the box never reflows the page; scrollbars suppressed via
|
are both dead: (a) box-sized viewports clip full-bleed widgets to their upper-left chunk
|
||||||
`overflow:hidden` html/body injection (background-transparent only otherwise). After each
|
("truncated to the upper-left corner regardless of scaling" — the image is desktop-line space),
|
||||||
navigation the manager queries the page's real content rect (`scrollWidth/scrollHeight` vs
|
(b) dragging the box reflowed the page (truncation/scrollbars). Scrollbars suppressed via
|
||||||
`innerWidth/innerHeight`) and **crops the capture to the actual content bounds, anchored at
|
`overflow:hidden` html/body injection. After each navigation the manager queries the page's real
|
||||||
(0,0)** — widgets that don't fill their viewport no longer stretch dead space across the box.
|
content rect (`scrollWidth/scrollHeight` vs `innerWidth/innerHeight`) and **crops the capture to
|
||||||
`Stretch="Fill"` maps the cropped frame edge-to-edge (box is covered; the fill/adornment rect
|
the actual content bounds, anchored at (0,0)**. `Stretch="Fill"` maps the frame flush under the
|
||||||
snaps to it). Graceful-error handling (item 9) is a follow-up. Rejected for the record:
|
box — selection/adornment box always bounds the widget, pinned to (0,0), for any widget geometry.
|
||||||
fixed-viewport 1920×1080 + `Uniform` (letterbox), CSS margin/100% reset (enlarged gaps),
|
Graceful-error handling (item 9) is a follow-up.
|
||||||
viewport==box (page reflow → truncation/scrollbars).
|
|
||||||
|
|
||||||
**Properties panel (2026-08-28):** web URI ✓/✕ icon buttons are `IsTabStop="False"` so Tab flows
|
**Properties panel (2026-08-28):** web URI ✓/✕ icon buttons are `IsTabStop="False"` so Tab flows
|
||||||
X→Y→W→H→URI; the ✕ button now clears the URI textbox (was reverting to the pre-accept snapshot).
|
X→Y→W→H→URI; the ✕ button now clears the URI textbox (was reverting to the pre-accept snapshot).
|
||||||
|
|||||||
@@ -20,7 +20,7 @@ public sealed class WebView2ManagerTests
|
|||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public void WebView2_Control_Size_Snapshots_Source_At_Register()
|
public void WebView2_Control_Size_Is_Canvas_Resolution_Regardless_Of_Source()
|
||||||
{
|
{
|
||||||
_app.Run(() =>
|
_app.Run(() =>
|
||||||
{
|
{
|
||||||
@@ -36,8 +36,8 @@ public sealed class WebView2ManagerTests
|
|||||||
manager.Register(source);
|
manager.Register(source);
|
||||||
|
|
||||||
var webView = panel.Children.OfType<WebView2>().First();
|
var webView = panel.Children.OfType<WebView2>().First();
|
||||||
Assert.Equal(640.0, webView.Width);
|
Assert.Equal(1920.0, webView.Width);
|
||||||
Assert.Equal(480.0, webView.Height);
|
Assert.Equal(1080.0, webView.Height);
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -62,13 +62,13 @@ public sealed class WebView2ManagerTests
|
|||||||
source.Width = 1024;
|
source.Width = 1024;
|
||||||
source.Height = 768;
|
source.Height = 768;
|
||||||
|
|
||||||
Assert.Equal(640.0, webView.Width);
|
Assert.Equal(1920.0, webView.Width);
|
||||||
Assert.Equal(480.0, webView.Height);
|
Assert.Equal(1080.0, webView.Height);
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public void WebView2_Control_Size_Minimum_Is_One()
|
public void WebView2_Control_Size_Ignores_Zero_Sized_Source()
|
||||||
{
|
{
|
||||||
_app.Run(() =>
|
_app.Run(() =>
|
||||||
{
|
{
|
||||||
@@ -84,8 +84,8 @@ public sealed class WebView2ManagerTests
|
|||||||
manager.Register(source);
|
manager.Register(source);
|
||||||
|
|
||||||
var webView = panel.Children.OfType<WebView2>().First();
|
var webView = panel.Children.OfType<WebView2>().First();
|
||||||
Assert.Equal(1.0, webView.Width);
|
Assert.Equal(1920.0, webView.Width);
|
||||||
Assert.Equal(1.0, webView.Height);
|
Assert.Equal(1080.0, webView.Height);
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user