docs: rewrite HANDOFF — tonight's 12-commit series, take-3 checklist, pending rulings, landmines refreshed (zero known failures era begins)

This commit is contained in:
2026-09-01 23:27:22 -07:00
parent 4509befb98
commit 7fcb2ad3da
+58 -43
View File
@@ -2,57 +2,72 @@
## Branch / Commit State
**`main`**, clean tree, **pushed to `origin/main` through `b4f3b52`** (user "push", 2026-09-01).
Session's five commits:
- `b4f3b52` — docs: HANDOFF rewrite (this file, pre-push state)
- `6799c40` — fix: first-native-launch crash (3 stacked faults) + RoundClip test root-caused → green
- `711ba54` — docs: HANDOFF rewrite + TASK 21 picker spec imported into TASKS.md
- `e1d8b10` — docs: v1 = feature-complete ruling; TASKs 32–36; out-of-product list; map-lie fixes
- `7c6ec3e` — docs: pre-GA posture (visibility lock, flash preview-only + escalation, audit → gold)
**`main`**, clean tree, **11 local commits NOT pushed** until the user's "commit and push" lands
with this file's commit (expect `main == origin/main` at handoff commit). Tonight's series
(newest first):
## What this session accomplished
- this commit — docs: HANDOFF rewrite
- `4509bef` — docs: record-OR-stream ruling, scheduling scope, SYNC provenance, playout declined
- `af0d372` — docs: take-two outcomes (arrival-stamping, resolver key, top-bar model, TASK 18 status)
- `89fee6c` — fix: webcam identity→device key + always-present Start + [light]LABEL[pill] order
- `97ffc42` — chore(pump): render/submit stage-timing stats, 5s windows
- `8dcaee0` — fix(encoder): stderr logging + any-exit-is-failure + resolver null logging
- `7f2bda8` — fix(audio): game meter × volume (`GameMeterHonestyTests`)
- `5ead064` — fix(audio): `_delayedMix` NRE — killed the "known failure", the hang, AND the log flood; LoopbackGain honest
- `5a1a3c5` — fix(18): stop ends everything — pills clear, failures roll back (`SessionTeardownTests`)
- `688682d` — feat(9): transition(complete) close-out (never existed before)
- `22b780e` — fix(ffmpeg): month-end re-pin (daily aged out → 404) + actionable wrap
1. **Product/PM gap audit** (the creator's "potholes and gone streets" fear): everything un-tasked
surfaced and ruled. Read ai.md → Monetization + TASKS.md → file end ("v1 = the finished product",
"Out of product — permanently", TASKs 32–36) — the rulings are IN the map now, not here.
2. **Fixed the first-startup crash** (user launched post-refactor for the first time — NRE):
SceneGraph ctor-order + window-scope styles the extracted LeftPanel couldn't see (full audit:
exactly 2 offenders). App verified booting + closing clean on the real desktop; real DB intact.
3. **Killed one of the two "known failures":** RoundClip was stale TEST code, not product —
`window.FindName` across namescopes + `VisualTreeHelper.HitTest` (which ignores input semantics
and returned the invisible WebViewHostPanel overlay for every point). `UIElement.InputHitTest`
proved the corner IS grabbable. Test green. Recipes recorded in MyMistakes.md.
## What tonight was
## Test suite truth (2026-09-01, verified natively)
Creator's first native runs since the refactor: startup crash → fixed (3 stacked faults); PM audit →
v1-complete declaration + out-of-product list (TASKS.md file end); first-ever real recordings → the
recording pipeline now demonstrably produces H.264+AAC MP4s (`Downloads\recordings\`, ffmpeg cached
in `%APPDATA%\ytLlive\tools\`).
- 247 tests, **246 pass**; the SOLE known failure is `AudioPipelineTests.Mix_HonorsProviderGains…`.
The creator's hint: they attribute it to "sound channel declaration/init". Clue spotted tonight:
real launches log "Audio: using system default mic + default output" TWICE (19:16 and 19:30
sessions) — possibly double mixer start or double log call; worth a look when the audio slice is
picked up. Not chased (out of scope, Good Dog).
- Per-class `dotnet.exe vstest` runs RealApp/MainWindow suites fine from WSL (6 classes + RoundClip
green tonight). Full-suite still hangs (WASAPI) — don't run it.
- The RealApp testhost shares `%APPDATA%\ytLlive\startup.log` with the real app — 'test-camera'
failure lines in there are test noise; check DB state by querying, not reading.
**Test suite: ZERO known failures** (audio class was the last — root-caused to an uninitialized
field; TASK 22's fault is recorded in its entry). Per-class Windows-host vstest runs everything
including RealApp; only the FULL suite hangs (WASAPI teardown — don't run it).
## What's next (creator's queue — do not expand)
## OPEN — do tomorrow, in order
**TASK 21 UI picker slice** (spec now lives in TASKS.md → TASK 21, imported from the old handoff so
it can't be lost by a rewrite). Then TASK 32 → 33 → 34 → 35 → text source → monetization chain →
MARCOM → TASK 36 gold pass, per "v1 execution order" in TASKS.md.
1. **Take 3 (user records ~30s, record-only):** read `%APPDATA%\ytLlive\startup.log` — the new
`FramePump stats: n/target frames per 5s, avg render Xms submit Yms` lines will name the stage
behind the ~2fps producer starvation (symptoms: short file + 30x time-lapse + garbled audio,
one cause — rawvideo stamps by arrival). Also check: webcam now IN the output (89fee6c),
meter follows the volume knob, Stop slides pills off + Start present, top bar grouping feels right.
Also: take-2's file stayed auto-named `ty-…-0000.mp4` — did the rename modal appear?
2. **Then code, one integration test per change:** starvation fix (from #1's data) → radio pills /
record-OR-stream enforcement (ruling captured in TASKS.md TASK 18; `BeginGoLive(alsoRecord)` dies)
→ top bar Option A **pending user approval** (his "still not correct" message predates tonight's
89fee6c — have him LOOK first) → empty-state ruling pending: disabled / rehearsal (my recommendation) /
default-record → SYNC slider placement ruling pending (feature is his, permanently; position is open).
3. **Un-asked questions** (don't nag, just have the answers ready): why-stupid confirmation on
simultaneous rec+stream was given (VOD copy + hardware drag) ✓; "other issues" from take 1/2 —
user mentioned them but never listed; take 2 preview questions.
## State of the app
Boots clean, records clean-ish (starvation pending), preview honest, top bar reordered per spec,
webcam-key fixed but NEVER verified in a real recording until take 3. The user's layout DB is
intact (real C920 row confirmed by direct sqlite read — the 'test-camera' log lines are testhost
noise, both processes share startup.log).
## Landmines
- Remote state: `main` == `origin/main` at `b4f3b52` (+ this push). Re-check `git log origin/main..main` after any further commits.
- Stale `testhost` can lock ytLive.dll (MSB3027) → `taskkill /PID N /F` via cmd.exe.
- WSL cannot spawn Linux ffmpeg from the Windows CLR shim; contract verification recipe + static
ffmpeg live at `/tmp/opencode/` (MyMistakes has the how-to).
- Pre-commit gate: `./scripts/verify.sh "<files>"` — but its full-suite step hangs; tonight's flow
(clean build + per-class vstest + scope-check) is the working substitute from WSL.
- Real-`MainWindow` tests MUST set `MainViewModel.LayoutPathOverride` (temp DB) or shutdown saves
pollute the user's real layout.
- testhost shares startup.log with the app — filter by time when triaging.
- Stale testhost/exe locks the DLL (MSB3027): `taskkill /F /IM ytLive.exe` / `testhost.exe` first.
- Do NOT run full-suite vstest (hangs); do NOT claim suite totals — per-class only.
- `AudioPipelineTests` is healthy now but was the "known failure" graveyard — any new failure
there means a live-loop regression; read the logged stack (catches now log WITH stack + 5s throttle).
- Real-`MainWindow` tests MUST use `LayoutPathOverride` + temp DB; `VolumePushOverride` seam exists
so volume-slider tests never touch the machine's speakers.
- verify.sh's full-suite step hangs from WSL — flow tonight: clean build (0 warnings) + per-class
vstest + scope-check, all through the Windows dotnet.exe host.
- ffmpeg pin: month-end rule recorded (TASKS.md); BtbN keeps dailies ~14 days.
## @ User note — no unsolicited roadmap
## @ User note
Work what's queued; report what changed; no forward-looking "what's next" lists unless asked.
Prefers short, spaced-out output over dense text (tired eyes — one idea per line beats a table).
No unsolicited roadmap/next-step lists — work the queue above, report what changed, keep responses
SHORT (his words, twice tonight: walls of text are not getting read). Good dog: one integration test
per change. Committing is expected; pushing on his word — tonight he said push with the handoff.