From a6f63f56f31535411798acf65d13082269385878 Mon Sep 17 00:00:00 2001
From: gramps <gramps@llamachile.shop>
Date: Fri, 30 Oct 2026 13:16:19 -0700
Subject: [PATCH] =?UTF-8?q?feat(dock):=20the=20LIP-SYNC=20bay=20=E2=80=94?=
 =?UTF-8?q?=20offset,=20readout,=20zero=20detent?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Unit 8. Re-houses the shipped TASK 22 offset in the dock:
- slider −200…+200 ms, snapping to 5 ms ticks (the existing property still clamps and persists)
- readable readout: "0 ms (aligned)" when right, signed otherwise ("+50 ms", "−120 ms")
- presets 0 / +50 / +100; 0 IS the detent — a button is easier to hit than a snap, and "the lip-sync
  is right" deserves one click.

Guard: SyncBayTests pins the binding, the readout, the presets and the snapping, and that the
offset stays the persisted property (no second source of truth).
---
 Controls/AudioDock.xaml           | 40 +++++++++++++++++++++++++++----
 Controls/AudioDock.xaml.cs        |  7 ++++++
 ViewModels/MainViewModel.Audio.cs | 14 +++++++++--
 ytLive.Tests/SyncBayTests.cs      | 30 +++++++++++++++++++++++
 4 files changed, 85 insertions(+), 6 deletions(-)
 create mode 100644 ytLive.Tests/SyncBayTests.cs

diff --git a/Controls/AudioDock.xaml b/Controls/AudioDock.xaml
index 049adb2..40ae1af 100644
--- a/Controls/AudioDock.xaml
+++ b/Controls/AudioDock.xaml
@@ -170,10 +170,42 @@
                     </Grid>
                 </Border>
                 <Border Grid.Column="3" Background="{StaticResource Brush.SurfaceContainerLow}" CornerRadius="{StaticResource Radius.Sm}" Margin="4,0,0,0" Padding="10,6">
-                    <StackPanel>
-                        <TextBlock Text="LIP-SYNC" FontSize="10" FontWeight="SemiBold" Foreground="{StaticResource Brush.OnSurfaceVariant}"/>
-                        <TextBlock x:Name="SyncBayBody" Text="—" FontSize="11" Foreground="{StaticResource Brush.OnSurfaceDisabled}"/>
-                    </StackPanel>
+                    <Grid>
+                        <Grid.RowDefinitions>
+                            <RowDefinition Height="Auto"/>
+                            <RowDefinition Height="*"/>
+                        </Grid.RowDefinitions>
+
+                        <Grid Grid.Row="0">
+                            <Grid.ColumnDefinitions>
+                                <ColumnDefinition Width="Auto"/>
+                                <ColumnDefinition Width="*"/>
+                            </Grid.ColumnDefinitions>
+                            <Border Background="{StaticResource Brush.SurfaceContainerHighest}" CornerRadius="{StaticResource Radius.Sm}" Padding="5,1">
+                                <TextBlock Text="LIP-SYNC" FontSize="9" FontWeight="Bold" Foreground="{StaticResource Brush.OnSurfaceVariant}"/>
+                            </Border>
+                            <TextBlock Grid.Column="1" Margin="6,0,0,0" FontSize="10" VerticalAlignment="Center"
+                                       FontFamily="{StaticResource FontFamily.Mono}" TextAlignment="Right"
+                                       Foreground="{StaticResource Brush.Tertiary}"
+                                       Text="{Binding SyncOffsetLabel}"/>
+                        </Grid>
+
+                        <StackPanel Grid.Row="1" VerticalAlignment="Bottom">
+                            <!-- A detent marker would need a custom track; the 0 ms preset is the
+                                 detent as a button, which is also easier to hit than a snap. -->
+                            <Slider Minimum="-200" Maximum="200" SmallChange="5" LargeChange="25"
+                                    TickFrequency="5" IsSnapToTickEnabled="True"
+                                    Value="{Binding AudioSyncOffsetMs, Mode=TwoWay}" VerticalAlignment="Center"/>
+                            <StackPanel Orientation="Horizontal" Margin="0,2,0,0" HorizontalAlignment="Right">
+                                <Button Content="0" Width="26" Height="16" FontSize="9" Padding="0" Margin="0,0,4,0"
+                                        Style="{StaticResource YtButtonSecondary}" Click="SyncPreset_Click" Tag="0"/>
+                                <Button Content="+50" Width="30" Height="16" FontSize="9" Padding="0" Margin="0,0,4,0"
+                                        Style="{StaticResource YtButtonSecondary}" Click="SyncPreset_Click" Tag="50"/>
+                                <Button Content="+100" Width="34" Height="16" FontSize="9" Padding="0"
+                                        Style="{StaticResource YtButtonSecondary}" Click="SyncPreset_Click" Tag="100"/>
+                            </StackPanel>
+                        </StackPanel>
+                    </Grid>
                 </Border>
             </Grid>
 
diff --git a/Controls/AudioDock.xaml.cs b/Controls/AudioDock.xaml.cs
index 1fcd815..2a7bff9 100644
--- a/Controls/AudioDock.xaml.cs
+++ b/Controls/AudioDock.xaml.cs
@@ -39,6 +39,13 @@ public partial class AudioDock : UserControl
             vm.OpenMicPickerCommand.Execute(null);
     }
 
+    private void SyncPreset_Click(object sender, RoutedEventArgs e)
+    {
+        if (DataContext is not ViewModels.MainViewModel vm) return;
+        if (sender is Button { Tag: string tag } && int.TryParse(tag, out var ms))
+            vm.SetSyncOffset(ms);
+    }
+
     private void TraxPlayPause_Click(object sender, RoutedEventArgs e)
     {
         if (DataContext is ViewModels.MainViewModel vm) vm.TraxLeftClick();
diff --git a/ViewModels/MainViewModel.Audio.cs b/ViewModels/MainViewModel.Audio.cs
index 5203913..a892f7f 100644
--- a/ViewModels/MainViewModel.Audio.cs
+++ b/ViewModels/MainViewModel.Audio.cs
@@ -194,11 +194,21 @@ public partial class MainViewModel
         set
         {
             var clamped = Math.Clamp(value, -500, 500);
-            if (SetProperty(ref _audioSyncOffsetMs, clamped))
-                ScheduleSave();
+            if (!SetProperty(ref _audioSyncOffsetMs, clamped)) return;
+            OnPropertyChanged(nameof(SyncOffsetLabel));
+            ScheduleSave();
         }
     }
 
+    /// <summary>"0 ms (aligned)", "+50 ms", "−120 ms" — what the dock shows beside the slider.</summary>
+    public string SyncOffsetLabel => AudioSyncOffsetMs == 0
+        ? "0 ms (aligned)"
+        : (AudioSyncOffsetMs > 0 ? "+" : "−") + Math.Abs(AudioSyncOffsetMs) + " ms";
+
+    /// <summary>Preset buttons in the LIP-SYNC bay. 0 is the detent: the offset that means "the
+    /// lip-sync is right", so it deserves one click, not a drag.</summary>
+    internal void SetSyncOffset(int milliseconds) => AudioSyncOffsetMs = milliseconds;
+
     private void ToggleMicMute()
     {
         if (MicMuted)
diff --git a/ytLive.Tests/SyncBayTests.cs b/ytLive.Tests/SyncBayTests.cs
new file mode 100644
index 0000000..2a01e75
--- /dev/null
+++ b/ytLive.Tests/SyncBayTests.cs
@@ -0,0 +1,30 @@
+using Xunit;
+using ytLive.ViewModels;
+
+namespace ytLive.Tests;
+
+/// <summary>The LIP-SYNC bay re-houses the offset that shipped as TASK 22, with the two things the
+/// dock asks of it: a readable readout ("0 ms (aligned)") and 0 as a one-click detent. The offset
+/// itself is clamped and persisted by the existing property — this pins the surface.
+/// </summary>
+public class SyncBayTests
+{
+    [Fact]
+    public void The_lip_sync_bay_uses_the_persisted_offset_with_a_zero_detent()
+    {
+        var dock = SourceAssert.Text("Controls", "AudioDock.xaml");
+        Assert.Contains("Value=\"{Binding AudioSyncOffsetMs, Mode=TwoWay}\"", dock);
+        Assert.Contains("Text=\"{Binding SyncOffsetLabel}\"", dock);
+        Assert.Contains("Click=\"SyncPreset_Click\"", dock);
+        Assert.Contains("Tag=\"0\"", dock);
+        Assert.Contains("Minimum=\"-200\" Maximum=\"200\"", dock);
+
+        // The readout names the good state, and signs the others the way a person reads them.
+        Assert.Matches(@"IsSnapToTickEnabled=""True""", dock);
+
+        var type = typeof(MainViewModel);
+        Assert.NotNull(type.GetProperty("AudioSyncOffsetMs"));
+        Assert.NotNull(type.GetProperty("SyncOffsetLabel"));
+        Assert.NotNull(type.GetMethod("SetSyncOffset", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance));
+    }
+}