From a7d1afc70b85660e39d740d7dc9fae38f2e7ffe5 Mon Sep 17 00:00:00 2001 From: gramps Date: Fri, 30 Oct 2026 12:39:36 -0700 Subject: [PATCH] fix(dock): spans the preview column and loses 20px MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - The dock now sits in the preview column (Grid.Column=1), so its left edge is the layers panel's right edge instead of starting under the brand column. It is a preview-column control, not a full-width footer. - Expanded height 168 → 148 (112 bays + 36 master strip): the mockup's number read as wasted space beneath the 154px scene strip. Guard: AudioDockLayoutTests pins 148 as the design number, so the constant cannot drift silently. --- MainWindow.xaml | 4 +++- Models/AudioDockLayout.cs | 6 ++++-- ytLive.Tests/AudioDockLayoutTests.cs | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/MainWindow.xaml b/MainWindow.xaml index 137b8bd..5b7b6ee 100644 --- a/MainWindow.xaml +++ b/MainWindow.xaml @@ -148,7 +148,9 @@ - + + diff --git a/Models/AudioDockLayout.cs b/Models/AudioDockLayout.cs index 3e71d9a..4c83a9f 100644 --- a/Models/AudioDockLayout.cs +++ b/Models/AudioDockLayout.cs @@ -2,7 +2,7 @@ namespace ytLive.Models; /// How tall the audio dock should be for a given window height. /// -/// Creator ruling (2026-10-30): the dock is 168px on a normal window and collapses to a 36px +/// Creator ruling (2026-10-30): the dock is 148px on a normal window and collapses to a 36px /// telemetry strip when the window is short, because at 1366×768 a full dock leaves ~398px for the /// preview and the composition starts letterboxing into a postage stamp. /// @@ -13,7 +13,9 @@ public static class AudioDockLayout /// default window is 1040, so a normal launch shows the full dock. public const double CollapseBelowHeight = 900; - public const double ExpandedHeight = 168; + /// 148 = 112 of bays + the 36px master strip. The mockup wanted 168; the creator + /// read that as wasted space under a 154px scene strip, so the bays lost 20px of air. + public const double ExpandedHeight = 148; public const double CollapsedHeight = 36; public static bool IsCollapsed(double windowHeight) => windowHeight < CollapseBelowHeight; diff --git a/ytLive.Tests/AudioDockLayoutTests.cs b/ytLive.Tests/AudioDockLayoutTests.cs index 144d611..015dc11 100644 --- a/ytLive.Tests/AudioDockLayoutTests.cs +++ b/ytLive.Tests/AudioDockLayoutTests.cs @@ -26,7 +26,7 @@ public class AudioDockLayoutTests Assert.True(AudioDockLayout.IsCollapsed(AudioDockLayout.CollapseBelowHeight - 1)); // The two heights are the design's numbers, not whatever looked fine. - Assert.Equal(168, AudioDockLayout.ExpandedHeight); + Assert.Equal(148, AudioDockLayout.ExpandedHeight); // 112 bays + 36 strip Assert.Equal(36, AudioDockLayout.CollapsedHeight); } }