fix(scoreboard): the defaults were never applied — a record struct zero-initialises
Creator's defaults: white text, Background ON (black, 20%), speed capped at 200 px/s, text size shown in real pixels, and "plate" dropped from the label. The important find is underneath those: `ScoreboardStyle` is a record STRUCT, and `new ScoreboardStyle()` zero-initialises — it does NOT run the constructor's parameter defaults. So the shipped strip had null text colour, NO background and zero opacity, whatever the source said. That is why the Background checkbox and the opacity slider looked like they had no code behind them: the renderer was faithfully drawing the zeros it was handed. An explicit parameterless constructor now carries the real defaults, and the renderer test asserts them (white / on / black / 0.20 / max speed 200) so this class of silent-zero cannot return. Readouts fixed too: the opacity and text-size setters never raised their own property, so the numbers never moved while the render did. Text size now reads "24 px" instead of a bare slider value, and snaps to whole pixels.
This commit is contained in:
@@ -17,6 +17,14 @@ public class ScoreboardRendererTests
|
||||
[Fact]
|
||||
public void The_strip_paints_the_plate_and_the_text_and_never_needs_a_scroll()
|
||||
{
|
||||
// The shipped defaults: white text, background ON, black, 20%.
|
||||
var defaults = new ScoreboardStyle();
|
||||
Assert.Equal("#FFFFFF", defaults.TextColor);
|
||||
Assert.True(defaults.BackgroundEnabled);
|
||||
Assert.Equal("#000000", defaults.BackgroundColor);
|
||||
Assert.Equal(0.20, defaults.BackgroundOpacity, 3);
|
||||
Assert.Equal(200, ytLive.Services.Compositor.ScoreboardPresenter.MaxPixelsPerSecond, 3);
|
||||
|
||||
Exception? failure = null;
|
||||
|
||||
var thread = new Thread(() =>
|
||||
|
||||
Reference in New Issue
Block a user