From c418288215fdc9cc7f0bc8fc11f0962be8426692 Mon Sep 17 00:00:00 2001
From: gramps <gramps@llamachile.shop>
Date: Sun, 1 Nov 2026 09:08:08 -0800
Subject: [PATCH] =?UTF-8?q?fix(settings):=20the=20App=20Settings=20panel?=
 =?UTF-8?q?=20scrolls=20=E2=80=94=20the=20lower=20options=20were=20clipped?=
 =?UTF-8?q?=20off-screen?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The shell is MaxHeight 700 and the settings panel had grown past it with no ScrollViewer,
so everything below roughly the transition section was unreachable. That is why 'Tablet
(Horizontal Rectangle)' existed in the XAML and in the model but never appeared in the app:
the shape control itself was cut off, not the option.

Panel row is now * with an Auto ScrollViewer, so every section is reachable and the next
one added cannot silently fall off the bottom.
---
 Controls/OverlayHost.xaml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/Controls/OverlayHost.xaml b/Controls/OverlayHost.xaml
index de535fd..604a23d 100644
--- a/Controls/OverlayHost.xaml
+++ b/Controls/OverlayHost.xaml
@@ -21,7 +21,7 @@
                 <Grid>
                     <Grid.RowDefinitions>
                         <RowDefinition Height="Auto"/>
-                        <RowDefinition Height="Auto"/>
+                        <RowDefinition Height="*"/>
                     </Grid.RowDefinitions>
 
                     <!-- Header -->
@@ -37,9 +37,14 @@
 
                     <!-- App Settings: broadcast fields live in the preview's
                          Text pull-out now — this panel keeps app-level prefs only.
-                         (Currently empty; the overlay shell stays for future use.) -->
-                    <StackPanel Grid.Row="1" Margin="0,8,0,0"
-                                Visibility="{Binding IsSettingsOpen, Converter={StaticResource BoolToVis}}">
+                         ⛔ The ScrollViewer is load-bearing: the shell is MaxHeight 700 and the
+                         panel has more sections than that (Recordings, Brand logo, Preview,
+                         transitions, Zoom box, Developer), so without it the lower options were
+                         clipped off-screen — which is how "Tablet (Horizontal Rectangle)" existed
+                         in the XAML yet never appeared in the app (2026-11-01). -->
+                    <ScrollViewer Grid.Row="1" VerticalScrollBarVisibility="Auto"
+                                  Visibility="{Binding IsSettingsOpen, Converter={StaticResource BoolToVis}}">
+                    <StackPanel Margin="0,8,0,0">
 
                         <TextBlock Text="Recordings" Foreground="{StaticResource Brush.OnSurfaceVariant}" FontSize="11" FontWeight="SemiBold" Margin="0,8,0,2"/>
                         <TextBlock Text="Default location" Foreground="{StaticResource Brush.OnSurfaceVariant}" FontSize="11" Margin="10,0,0,2"/>
@@ -128,6 +133,7 @@
                              this inside #if DEBUG. Never put content here directly. -->
                         <StackPanel x:Name="DeveloperPanelHost"/>
                     </StackPanel>
+                    </ScrollViewer>
 
                     <!-- Report Bug -->
                     <StackPanel Grid.Row="1" Margin="0,16,0,0"