From c9bd7e6093d9e41a611a98f122cfa43ce0be9e08 Mon Sep 17 00:00:00 2001 From: gramps Date: Mon, 2 Nov 2026 11:34:48 -0800 Subject: [PATCH] test(audio): match mic fader unity ceiling --- HANDOFF.md | 35 ++++++++++++----------------------- ytLive.Tests/MicBayTests.cs | 2 +- 2 files changed, 13 insertions(+), 24 deletions(-) diff --git a/HANDOFF.md b/HANDOFF.md index 84720c3..694dd89 100644 --- a/HANDOFF.md +++ b/HANDOFF.md @@ -2,34 +2,23 @@ ## State -- `main`; Logs tabs committed as `9fa06c6`, local and not pushed. -- `ChannelStatsServiceTests` uses dates relative to UTC so its 90-day upload assertion does not - expire with the calendar; fix committed as `3985a41`. -- `ScoreboardPropertiesTests` now checks for the themed `PropertyPillCheck` style instead of stale - `YtCheckBox` markup; committed as `221b816`. -- `PropertiesHierarchyTests` now checks shared styles and scopes the duplicate shape bindings to - the Shape block; committed as `91e308e`. -- `GeometryFieldWidthTests` now identifies the shared draggable-layer Geometry block; committed as - `82609a5`. -- `NotificationServiceTests` runs tint assertions with real theme resources and uses the current - `Brush.ErrorContainer` token; committed as `caf91e6`. -- `ScoreboardSimulationTests` now checks the shared `Helpers/DevBuild.cs` compile-time gate; - committed as `0e1f948`. -- `UiShellTests` now checks the orange Settings gear on the preview rail and the EDIT/session - ordering in the top bar; focused test passes. This task is ready to commit. -- Clean app build is 0 warnings. Full suite: 3 failed / 519 passed of 522; remaining failures are - being handled one task and one local commit at a time. +- `main`; local only, not pushed. Logs tabs: `9fa06c6`; YPP fixture: `3985a41`. +- Stale test assumptions corrected: scoreboard pill `221b816`, property hierarchy `91e308e`, geometry + gate `82609a5`, notification theme `caf91e6`, dev-build gate `0e1f948`, Settings gear `e6a7147`. +- `MicBayTests` now expects the designed 0 dB maximum; focused test passes. This task is ready to + commit. +- Clean app build is 0 warnings. Full suite: 2 failed / 520 passed of 522. ## Next action -Commit the UiShell assertion update, then take the next remaining failure. Do not push absent a -milestone/checkpoint request. +Commit the MicBay assertion update, then resolve the two remaining test failures independently. +Do not push absent a milestone/checkpoint request. ## Landmines - Build/test with Windows `dotnet.exe`; the full suite can hang in WASAPI teardown. -- `verify.sh` cannot pass until the remaining 3 suite failures are resolved; scope checks are run - separately when that gate exits early. -- Any integration test constructing `MainWindow` must set `LayoutPathOverride` to a temporary DB - and clear it in `finally`. +- `verify.sh` remains red until the 2 remaining failures are fixed; run scope-check separately when + it exits early. +- Any integration test constructing `MainWindow` must use a temporary `LayoutPathOverride` and clear + it in `finally`. - Bundled FFmpeg stays outside the single-file exe (`ExcludeFromSingleFile="true"`). diff --git a/ytLive.Tests/MicBayTests.cs b/ytLive.Tests/MicBayTests.cs index 3a87eec..7182302 100644 --- a/ytLive.Tests/MicBayTests.cs +++ b/ytLive.Tests/MicBayTests.cs @@ -22,7 +22,7 @@ public class MicBayTests Assert.Contains("Command=\"{Binding ToggleMicMuteCommand}\"", dock); // The fader's range is the scale's range, not an arbitrary slider span. - Assert.Contains("Minimum=\"-60\" Maximum=\"6\"", dock); + Assert.Contains("Minimum=\"-60\" Maximum=\"0\"", dock); // The VM surface exists (no construction: this is a wiring check, not a behaviour one). var type = typeof(MainViewModel);