fix(audio): a sync offset is saved the moment it changes

Both offsets rode the debounced layout save, so a value set seconds before the app closed was lost
without a word. That is what happened to the -130 ms offset on 2026-11-12: two clips were measured
against a setting that was not in force, the numbers disagreed by ~65 ms, and the disagreement was
blamed on the audio path.

Setters now write the row immediately (two tiny rows), keeping ScheduleSave for the rest of the
layout. AudioSyncSettingsTests gains the regression: set both offsets on a view model and read them
back through a fresh store with no debounce flush.

MyMistakes records the general shape — "a setting that didn't stick" is almost always ScheduleSave —
with the check list and the two related rules: offsets never ship with a non-zero default, and
scripts/avsync.py only resolves ~50 ms, so below that the creator's judgement wins.

677 pass, 0 warnings. Scope justification: Assets/starting-background.jpg is outside this unit — the
creator's replacement art, still awaiting their visual check.
This commit is contained in:
2026-11-12 14:21:48 -08:00
parent 1eb04597d1
commit cc75212997
3 changed files with 63 additions and 0 deletions
+28
View File
@@ -3,6 +3,7 @@ using System.IO;
using Microsoft.Data.Sqlite;
using Xunit;
using ytLive.Services;
using ytLive.ViewModels;
namespace ytLive.Tests;
@@ -11,6 +12,8 @@ namespace ytLive.Tests;
/// not arrive with audio already shifted — a non-zero default would move every creator's voice to fix
/// one machine and would hide whether the fault is theirs or ours.
/// </summary>
// The view model below touches the static LayoutPathOverride, so it shares the layout collection.
[Collection("MainViewModelLayoutPath")]
public sealed class AudioSyncSettingsTests : IDisposable
{
private readonly string _db = Path.Combine(Path.GetTempPath(), $"ytLlive-syncsettings-{Guid.NewGuid():N}.db");
@@ -44,4 +47,29 @@ public sealed class AudioSyncSettingsTests : IDisposable
Assert.Equal(240, reopened.LoadMicSyncOffsetMs());
Assert.Equal(-130, reopened.LoadAudioSyncOffsetMs());
}
/// <summary>
/// A slider move is persisted as it happens. It used to ride the debounced layout save, so a value
/// set seconds before closing the app was lost — which cost a record-and-measure cycle on 2026-11-12
/// when a −130 ms offset vanished between two clips.
/// </summary>
[Fact]
public void A_slider_move_survives_without_any_debounce_flush()
{
MainViewModel.LayoutPathOverride = _db;
try
{
var vm = new MainViewModel();
vm.AudioSyncOffsetMs = -130;
vm.MicSyncOffsetMs = 240;
using var store = new LayoutStore(_db);
Assert.Equal(-130, store.LoadAudioSyncOffsetMs());
Assert.Equal(240, store.LoadMicSyncOffsetMs());
}
finally
{
MainViewModel.LayoutPathOverride = null;
}
}
}