From f67a263ccdad7bbf5309d2f7e6794b7d817fd1a6 Mon Sep 17 00:00:00 2001
From: gramps <gramps@llamachile.shop>
Date: Tue, 27 Oct 2026 09:12:37 -0700
Subject: [PATCH] App Settings: transition type and length picker

Cut/Fade/Move and a 100-2000 ms length, bound to the view model; changes save with the layout.
Test: TransitionPickerTests. Not pushed.
---
 Controls/OverlayHost.xaml             | 14 ++++++-
 TASKS.md                              |  2 +-
 ViewModels/MainViewModel.Scenes.cs    |  4 +-
 ytLive.Tests/TransitionPickerTests.cs | 54 +++++++++++++++++++++++++++
 4 files changed, 70 insertions(+), 4 deletions(-)
 create mode 100644 ytLive.Tests/TransitionPickerTests.cs

diff --git a/Controls/OverlayHost.xaml b/Controls/OverlayHost.xaml
index c3224fa..a66718d 100644
--- a/Controls/OverlayHost.xaml
+++ b/Controls/OverlayHost.xaml
@@ -2,7 +2,8 @@
              xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
              xmlns:Helpers="clr-namespace:ytLive.Helpers"
-             xmlns:Models="clr-namespace:ytLive.Models">
+             xmlns:Models="clr-namespace:ytLive.Models"
+             xmlns:services="clr-namespace:ytLive.Services">
         <Grid Grid.RowSpan="3"
               Visibility="{Binding IsAnyOverlayOpen, Converter={StaticResource BoolToVis}}">
             <Button Background="#99000000" BorderThickness="0" Cursor="Hand"
@@ -55,6 +56,17 @@
                             <ComboBoxItem Content="Phone (Vertical Rectangle)" Tag="{x:Static Models:ZoomShape.VerticalRectangle}"/>
                             <ComboBoxItem Content="Tablet (Horizontal Rectangle)" Tag="{x:Static Models:ZoomShape.HorizontalRectangle}"/>
                         </ComboBox>
+                        <TextBlock Text="Scene Transition" Style="{StaticResource YtLabel}" Margin="0,12,0,4"/>
+                        <ComboBox Style="{StaticResource YtComboBox}" SelectedValue="{Binding SelectedTransitionType}" SelectedValuePath="Tag">
+                            <ComboBoxItem Content="Cut" Tag="{x:Static services:TransitionType.Cut}"/>
+                            <ComboBoxItem Content="Fade" Tag="{x:Static services:TransitionType.Fade}"/>
+                            <ComboBoxItem Content="Move" Tag="{x:Static services:TransitionType.Move}"/>
+                        </ComboBox>
+                        <TextBlock Style="{StaticResource YtLabel}" Margin="0,8,0,4">
+                            <Run Text="Transition length: "/><Run Text="{Binding TransitionDurationMs, StringFormat={}{0:0} ms}"/>
+                        </TextBlock>
+                        <Slider Minimum="100" Maximum="2000" TickFrequency="50" IsSnapToTickEnabled="True"
+                                Value="{Binding TransitionDurationMs, Mode=TwoWay}"/>
                     </StackPanel>
 
                     <!-- Report Bug -->
diff --git a/TASKS.md b/TASKS.md
index 27c5bcf..c8edc59 100644
--- a/TASKS.md
+++ b/TASKS.md
@@ -455,7 +455,7 @@ These were explicitly ruled out:
 ## Transitions & brand logo (queued 2026-10-27)
 
 - ✅ **Fade fix** — swaps fade from the outgoing picture (`TransitionFadeTests`). On-screen check pending.
-- ☐ **Transition picker** in App Settings (type + duration).
+- ✅ **Transition picker** in App Settings (type + duration), saved with the layout (`TransitionPickerTests`).
 - ☐ **Wipe** — CPU blend, direction setting.
 - ☐ **Move** — persistent layers (per-layer "carry across scenes" flag), per-scene placement, fixed z band.
 - ☐ **Brand logo** — permanent "Brand logo" layer above background in every scene; file in App Settings
diff --git a/ViewModels/MainViewModel.Scenes.cs b/ViewModels/MainViewModel.Scenes.cs
index 88a6123..5879b5e 100644
--- a/ViewModels/MainViewModel.Scenes.cs
+++ b/ViewModels/MainViewModel.Scenes.cs
@@ -97,14 +97,14 @@ public partial class MainViewModel
     public TransitionType SelectedTransitionType
     {
         get => _selectedTransitionType;
-        set => SetProperty(ref _selectedTransitionType, value);
+        set { if (SetProperty(ref _selectedTransitionType, value)) ScheduleSave(); }
     }
     private TransitionType _selectedTransitionType = TransitionType.Fade;
 
     public double TransitionDurationMs
     {
         get => _transitionDurationMs;
-        set => SetProperty(ref _transitionDurationMs, value);
+        set { if (SetProperty(ref _transitionDurationMs, value)) ScheduleSave(); }
     }
     private double _transitionDurationMs = 300;
 
diff --git a/ytLive.Tests/TransitionPickerTests.cs b/ytLive.Tests/TransitionPickerTests.cs
new file mode 100644
index 0000000..3a5184e
--- /dev/null
+++ b/ytLive.Tests/TransitionPickerTests.cs
@@ -0,0 +1,54 @@
+using System;
+using System.ComponentModel;
+using Xunit;
+using ytLive.Services;
+using ytLive.ViewModels;
+
+namespace ytLive.Tests;
+
+/// <summary>
+/// The App Settings transition picker drives the view model: type and length changes
+/// notify the bound controls.
+/// </summary>
+[Collection("RealApp")]
+public sealed class TransitionPickerTests
+{
+    private readonly RealAppHost _app;
+
+    public TransitionPickerTests(RealAppHost app) => _app = app;
+
+    [Fact]
+    public void Transition_Type_And_Length_Notify_The_Settings_Picker()
+    {
+        _app.Run(Run);
+    }
+
+    private static void Run()
+    {
+        var tempDb = System.IO.Path.Combine(System.IO.Path.GetTempPath(), $"ytLlive-transition-{Guid.NewGuid():N}.db");
+        MainViewModel.LayoutPathOverride = tempDb;
+        try
+        {
+            using (var schema = new LayoutStore(tempDb)) { }
+            Microsoft.Data.Sqlite.SqliteConnection.ClearAllPools();
+
+            var vm = new MainViewModel();
+            var raised = new System.Collections.Generic.List<string>();
+            ((INotifyPropertyChanged)vm).PropertyChanged += (_, e) => raised.Add(e.PropertyName ?? "");
+
+            vm.SelectedTransitionType = TransitionType.Move;
+            vm.TransitionDurationMs = 750;
+
+            Assert.Equal(TransitionType.Move, vm.SelectedTransitionType);
+            Assert.Equal(750, vm.TransitionDurationMs);
+            Assert.Contains(nameof(MainViewModel.SelectedTransitionType), raised);
+            Assert.Contains(nameof(MainViewModel.TransitionDurationMs), raised);
+        }
+        finally
+        {
+            MainViewModel.LayoutPathOverride = null;
+            Microsoft.Data.Sqlite.SqliteConnection.ClearAllPools();
+            try { System.IO.File.Delete(tempDb); } catch { }
+        }
+    }
+}