6799c40175
User launch (2026-09-01 19:07) NRE'd in MainViewModel ctor:
1. SceneGraph (TASK 31) was 'null!'-declared, assigned mid-ctor, but Scenes is touched
~120 lines earlier — field-initialized now.
2. LeftPanel extraction (c9fd1bd) moved StaticResource users (EyeButton/EyeIconStyle)
into a UserControl while the styles stayed window-scope — invisible at parse time;
moved to Themes/Controls.xaml (app scope, the existing rule). Full audit: these were
the only two offenders (grep of Controls/*.xaml StaticResource keys vs app dictionary).
3. RoundClipInteractionTests — the second 'known failure' the map never explained: it
was two stale-test layers (window.FindName across the new UserControl namescope +
VisualTreeHelper.HitTest, which returned the IsHitTestVisible=False WebViewHostPanel
overlay for EVERY point; UIElement.InputHitTest — the real input pipeline — shows the
corner IS grabbable in both Traditional and Round). Test fixed, no product bug.
Verified: clean rebuild 0 warnings; app boots (log shows full MainWindow loaded; user
clicked + closed, zero new exceptions; real DB Webcam row = the genuine C920, untouched);
RoundClip + 6 RealApp classes pass natively per-class.
Docs: ai.md known-failure note → 246/247 (audio only); TASK 31 verification paragraph
corrected ('cannot run headless' overstated — per-class Windows-host vstest runs them);
MyMistakes: InputHitTest-vs-VTH recipe + namescope/app-style + shared-log facts.
Spin-guard citations: WPF Visual Tree Overview (InputHitTest vs VisualTreeHelper hit
semantics) + XAML namescope docs, learn.microsoft.com.
144 lines
5.5 KiB
C#
144 lines
5.5 KiB
C#
using System;
|
|
using System.Threading;
|
|
using System.Windows;
|
|
using System.Windows.Controls;
|
|
using System.Windows.Media;
|
|
using System.Windows.Shapes;
|
|
using System.Windows.Threading;
|
|
using Microsoft.Data.Sqlite;
|
|
using Xunit;
|
|
using ytLive.Models;
|
|
using ytLive.ViewModels;
|
|
|
|
namespace ytLive.Tests;
|
|
|
|
/// <summary>
|
|
/// Reproduces the real MainWindow preview to check the round-clip corner
|
|
/// handle: whether a click at the corner actually stays inside the preview
|
|
/// (doesn't fall through and deselect the source) and whether the round clip
|
|
/// renders as a circle rather than an oval.
|
|
/// </summary>
|
|
[Collection("RealApp")]
|
|
public sealed class RoundClipInteractionTests
|
|
{
|
|
private readonly RealAppHost _app;
|
|
|
|
public RoundClipInteractionTests(RealAppHost app)
|
|
{
|
|
_app = app;
|
|
}
|
|
|
|
[Fact]
|
|
public void Round_Clip_Corner_Is_Grabbable_And_Shape_Is_Circle()
|
|
{
|
|
_app.Run(Run);
|
|
}
|
|
|
|
|
|
private void Run()
|
|
{
|
|
// Never let the real MainWindow read/write the user's actual layout DB —
|
|
// Shutdown() saves the layout, which would persist these test sources
|
|
// over the real ones. Point it at a throwaway temp DB instead.
|
|
var tempDb = System.IO.Path.Combine(System.IO.Path.GetTempPath(), $"ytLlive-test-{Guid.NewGuid():N}.db");
|
|
MainViewModel.LayoutPathOverride = tempDb;
|
|
var window = new MainWindow();
|
|
var vm = (MainViewModel)window.DataContext;
|
|
try
|
|
{
|
|
window.Show();
|
|
window.UpdateLayout();
|
|
|
|
var scene = vm.StagedScene!;
|
|
var webcam = new WebcamSceneConfig
|
|
{
|
|
WebcamId = "test-camera",
|
|
Name = "Webcam",
|
|
X = 1408,
|
|
Y = 778,
|
|
Width = 480,
|
|
Height = 270,
|
|
};
|
|
scene.Elements.Add(webcam);
|
|
vm.SelectedElement = webcam;
|
|
window.UpdateLayout();
|
|
|
|
// PreviewGrid/CanvasGrid moved into Controls/PreviewPane.xaml during the
|
|
// component refactor — a UserControl owns its own namescope, so window.FindName
|
|
// returns null for them. Resolve through the pane (found by its window-level name).
|
|
var pane = (System.Windows.Controls.UserControl)window.FindName("PreviewPane")!;
|
|
var previewGrid = (Grid)pane.FindName("PreviewGrid")!;
|
|
var canvasGrid = (Grid)pane.FindName("CanvasGrid")!;
|
|
var toWindow = canvasGrid.TransformToVisual(window);
|
|
|
|
var corner = new Point(webcam.X + webcam.Width, webcam.Y + webcam.Height);
|
|
|
|
foreach (var shape in new[] { ClipShape.Traditional, ClipShape.Round })
|
|
{
|
|
webcam.ClipShape = shape;
|
|
window.UpdateLayout();
|
|
|
|
var cornerInWindow = toWindow.Transform(corner);
|
|
|
|
// A click on the corner must land inside the preview (descendant
|
|
// of PreviewGrid); otherwise Window_PreviewMouseLeftButtonDown
|
|
// deselects the source and the handle can never be grabbed.
|
|
// UIElement.InputHitTest IS the input pipeline — what Mouse uses.
|
|
// Do NOT use VisualTreeHelper.HitTest here: it returned the window's
|
|
// non-hit-testable WebViewHostPanel overlay for EVERY point (it does
|
|
// not model IsHitTestVisible input semantics) — the bug this test
|
|
// "found" for months was this wrong API (root-caused 2026-09-01).
|
|
var hit = window.InputHitTest(cornerInWindow) as DependencyObject;
|
|
var grabbable = hit != null && IsDescendantOf(hit, previewGrid);
|
|
|
|
Assert.True(grabbable,
|
|
$"{shape}: corner click fell through to '{hit?.GetType().Name ?? "null"}' " +
|
|
"so the source gets deselected before the resize handler runs");
|
|
}
|
|
|
|
// The round clip must render as a circle (square bounding box), not an oval.
|
|
webcam.ClipShape = ClipShape.Round;
|
|
window.UpdateLayout();
|
|
var clip = FindRoundClip(window);
|
|
Assert.NotNull(clip);
|
|
var geometry = Assert.IsType<EllipseGeometry>(clip!.Clip);
|
|
Assert.Equal(0.5, geometry.Center.X, 1.0);
|
|
Assert.Equal(0.5, geometry.Center.Y, 1.0);
|
|
Assert.Equal(0.5, geometry.RadiusX, 1.0);
|
|
Assert.Equal(0.5, geometry.RadiusY, 1.0);
|
|
Assert.Equal(clip.ActualWidth, clip.ActualHeight, 1.0);
|
|
}
|
|
finally
|
|
{
|
|
window.Close();
|
|
MainViewModel.LayoutPathOverride = null;
|
|
SqliteConnection.ClearAllPools();
|
|
try { System.IO.File.Delete(tempDb); } catch { /* best-effort cleanup */ }
|
|
}
|
|
}
|
|
|
|
private static Image? FindRoundClip(Window window)
|
|
{
|
|
return Walk(window, element => element is Image i && i.IsVisible && i.Clip is EllipseGeometry) as Image;
|
|
}
|
|
|
|
private static DependencyObject? Walk(DependencyObject parent, Func<DependencyObject, bool> predicate)
|
|
{
|
|
for (var i = 0; i < VisualTreeHelper.GetChildrenCount(parent); i++)
|
|
{
|
|
var child = VisualTreeHelper.GetChild(parent, i);
|
|
if (predicate(child)) return child;
|
|
var found = Walk(child, predicate);
|
|
if (found != null) return found;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
private static bool IsDescendantOf(DependencyObject? child, DependencyObject ancestor)
|
|
{
|
|
while (child != null && !ReferenceEquals(child, ancestor))
|
|
child = VisualTreeHelper.GetParent(child);
|
|
return child != null;
|
|
}
|
|
}
|