Reported 2026-09-27: click avatar -> Change Account -> cancel in the Google chooser -> back to a signed-out app, then "cannot sign-in because the callback url was not released". Two independent defects: 1. ChangeAccountAsync ran `await SignOutYouTubeAsync(); await SignInAsync();`. SignOutYouTubeAsync -> TokenStore.Clear() -> deletes ytLlive.auth, so the working account's token was destroyed before the browser even opened. It is now just `await SignInAsync()`: success overwrites the token via the sessionChanged hook, cancel/failure keeps the current session. The explicit sign-out was never needed. 2. Abandoning the browser gives the app no signal, so the OAuth attempt held localhost:8765 for its full 5-minute timeout and a retry could not bind. A new AuthenticateAsync now cancels and awaits the abandoned attempt first. That takeover is serialised by a SemaphoreSlim: the first version cleared the in-flight marker before awaiting, so a caller arriving in that window saw a free port and raced to bind it -- reproducing the very failure it was written to prevent. My own test caught that; reasoning had "proved" it fine. Also adds an `openBrowser` ctor seam so tests never shell out to a real browser, and corrects the ai.md line that documented "Logout / Change Account -> SignOutYouTubeAsync" as intended behaviour. Test: YouTubeAuthServiceTests.RetryingAfterAnAbandonedAttempt_ReleasesTheCallbackPort Full suite 370/370, 0 warnings. Coverage gap noted in HANDOFF.md: the ordering fix has no automated test because _youtubeAuth is hardcoded in MainViewModel and ChangeAccountAsync is private. The reported cross-instance effect is NOT this cause and stays open -- no code path can sign out a second instance (per-instance TokenStore, local delete, no server-side revoke).
236 lines
9.1 KiB
C#
236 lines
9.1 KiB
C#
using System.Diagnostics;
|
|
using System.Net;
|
|
using System.Net.Http;
|
|
using System.Text;
|
|
using System.Text.Json;
|
|
using ytLive.Models;
|
|
|
|
namespace ytLive.Services;
|
|
|
|
/// <summary>
|
|
/// Handles YouTube OAuth2 authentication flow.
|
|
/// Uses a local HTTP listener for the redirect callback.
|
|
/// </summary>
|
|
public class YouTubeAuthService
|
|
{
|
|
private const string AuthorizationEndpoint = "https://accounts.google.com/o/oauth2/v2/auth";
|
|
private const string TokenEndpoint = "https://oauth2.googleapis.com/token";
|
|
private const string Scope = "https://www.googleapis.com/auth/youtube https://www.googleapis.com/auth/youtube.force-ssl";
|
|
|
|
private readonly string _clientId;
|
|
private readonly string _clientSecret;
|
|
private readonly HttpClient _http;
|
|
private readonly Action<YouTubeChannel>? _sessionChanged;
|
|
private readonly Action<string> _openBrowser;
|
|
|
|
/// <summary>Serialises "take over from the previous attempt". Without this, two
|
|
/// overlapping calls both see a free port and race to bind it, which is the same
|
|
/// failure the cancel-and-await is meant to prevent.</summary>
|
|
private readonly SemaphoreSlim _authGate = new(1, 1);
|
|
|
|
/// <summary>The attempt currently holding the loopback callback port, if any.
|
|
/// A creator who abandons the Google account chooser gives the app no signal, so
|
|
/// the attempt simply waits out its 5-minute timeout while still holding port
|
|
/// 8765 — and a retry in that window cannot bind. A new attempt cancels and
|
|
/// awaits the abandoned one first, which releases the port (creator report
|
|
/// 2026-09-27: "cannot sign-in because the callback url was not released").
|
|
/// Both fields below are only touched while holding <see cref="_authGate"/>.</summary>
|
|
private Task<YouTubeChannel?>? _authInFlight;
|
|
private CancellationTokenSource? _authCts;
|
|
|
|
public YouTubeChannel? CurrentChannel { get; private set; }
|
|
|
|
public YouTubeAuthService(string clientId, string clientSecret, HttpClient? http = null,
|
|
Action<YouTubeChannel>? sessionChanged = null,
|
|
Action<string>? openBrowser = null)
|
|
{
|
|
_clientId = clientId;
|
|
_clientSecret = clientSecret;
|
|
_http = http ?? new HttpClient();
|
|
_sessionChanged = sessionChanged;
|
|
// Seam: the real flow shells out to the default browser, which a test must not do.
|
|
_openBrowser = openBrowser ?? (url =>
|
|
Process.Start(new ProcessStartInfo(url) { UseShellExecute = true }));
|
|
}
|
|
|
|
/// <summary>Replaces the current session (used when a saved token loads at startup).</summary>
|
|
public void SetSession(YouTubeChannel channel)
|
|
{
|
|
CurrentChannel = channel;
|
|
}
|
|
|
|
/// <summary>Signs out: drops the in-memory session (a graceful End Livestream clears the saved token via the caller).</summary>
|
|
public void ClearSession()
|
|
{
|
|
CurrentChannel = null;
|
|
}
|
|
|
|
public string GetAuthorizationUrl(string redirectUri)
|
|
{
|
|
var query = new[]
|
|
{
|
|
("client_id", _clientId),
|
|
("redirect_uri", redirectUri),
|
|
("response_type", "code"),
|
|
("scope", Scope),
|
|
("access_type", "offline"),
|
|
("prompt", "consent"),
|
|
};
|
|
|
|
var encoded = string.Join("&", query.Select(kv =>
|
|
$"{Uri.EscapeDataString(kv.Item1)}={Uri.EscapeDataString(kv.Item2)}"));
|
|
|
|
return $"{AuthorizationEndpoint}?{encoded}";
|
|
}
|
|
|
|
public async Task<YouTubeChannel?> AuthenticateAsync()
|
|
{
|
|
if (string.IsNullOrWhiteSpace(_clientId) || string.IsNullOrWhiteSpace(_clientSecret))
|
|
return null;
|
|
|
|
// Taking over from an abandoned attempt has to be atomic: cancel it, wait for
|
|
// it to actually let go of the port, then bind. Letting the gate go before the
|
|
// bind reopens the race the takeover exists to close.
|
|
Task<YouTubeChannel?> attempt;
|
|
await _authGate.WaitAsync().ConfigureAwait(false);
|
|
try
|
|
{
|
|
var previousCts = _authCts;
|
|
_authCts = null;
|
|
previousCts?.Cancel();
|
|
|
|
if (_authInFlight is { } previous)
|
|
{
|
|
try { await previous.ConfigureAwait(false); } catch { /* its result is irrelevant */ }
|
|
_authInFlight = null;
|
|
}
|
|
|
|
var cts = new CancellationTokenSource(TimeSpan.FromMinutes(5));
|
|
_authCts = cts;
|
|
_authInFlight = attempt = RunAuthFlowAsync(cts.Token);
|
|
}
|
|
finally
|
|
{
|
|
_authGate.Release();
|
|
}
|
|
|
|
return await attempt.ConfigureAwait(false);
|
|
}
|
|
|
|
private async Task<YouTubeChannel?> RunAuthFlowAsync(CancellationToken cancellationToken)
|
|
{
|
|
const int port = 8765;
|
|
var redirectUri = $"http://localhost:{port}/oauth2/callback";
|
|
|
|
using var listener = new HttpListener();
|
|
listener.Prefixes.Add($"{redirectUri}/");
|
|
listener.Start();
|
|
|
|
_openBrowser(GetAuthorizationUrl(redirectUri));
|
|
|
|
HttpListenerContext context;
|
|
try
|
|
{
|
|
context = await listener.GetContextAsync().WaitAsync(cancellationToken);
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
return null;
|
|
}
|
|
|
|
var code = context.Request.QueryString["code"];
|
|
var error = context.Request.QueryString["error"];
|
|
|
|
var html = error != null
|
|
? "<html><body style=\"font-family:sans-serif\"><h2>Sign-in failed</h2><p>You can close this window and return to LlamaCasty.</p></body></html>"
|
|
: "<html><body style=\"font-family:sans-serif\"><h2>Sign-in successful!</h2><p>You can close this window and return to LlamaCasty.</p></body></html>";
|
|
var buffer = Encoding.UTF8.GetBytes(html);
|
|
context.Response.ContentType = "text/html; charset=utf-8";
|
|
context.Response.ContentLength64 = buffer.Length;
|
|
await context.Response.OutputStream.WriteAsync(buffer);
|
|
context.Response.Close();
|
|
|
|
if (error != null || string.IsNullOrEmpty(code))
|
|
return null;
|
|
|
|
return await ExchangeCodeForToken(code, redirectUri);
|
|
}
|
|
|
|
public async Task<YouTubeChannel?> ExchangeCodeForToken(string code, string redirectUri)
|
|
{
|
|
var body = new FormUrlEncodedContent(new Dictionary<string, string>
|
|
{
|
|
["code"] = code,
|
|
["client_id"] = _clientId,
|
|
["client_secret"] = _clientSecret,
|
|
["redirect_uri"] = redirectUri,
|
|
["grant_type"] = "authorization_code"
|
|
});
|
|
|
|
var response = await _http.PostAsync(TokenEndpoint, body);
|
|
if (!response.IsSuccessStatusCode)
|
|
return null;
|
|
|
|
var json = await response.Content.ReadAsStringAsync();
|
|
var tokenData = JsonSerializer.Deserialize<JsonElement>(json);
|
|
|
|
var accessToken = tokenData.GetProperty("access_token").GetString()!;
|
|
var refreshToken = tokenData.GetProperty("refresh_token").GetString()!;
|
|
var expiresIn = tokenData.GetProperty("expires_in").GetInt32();
|
|
|
|
// Fetch channel info
|
|
return await FetchChannelInfo(accessToken, refreshToken, expiresIn);
|
|
}
|
|
|
|
public async Task<bool> RefreshToken()
|
|
{
|
|
if (CurrentChannel == null) return false;
|
|
|
|
var body = new FormUrlEncodedContent(new Dictionary<string, string>
|
|
{
|
|
["refresh_token"] = CurrentChannel.RefreshToken,
|
|
["client_id"] = _clientId,
|
|
["client_secret"] = _clientSecret,
|
|
["grant_type"] = "refresh_token"
|
|
});
|
|
|
|
var response = await _http.PostAsync(TokenEndpoint, body);
|
|
if (!response.IsSuccessStatusCode) return false;
|
|
|
|
var json = await response.Content.ReadAsStringAsync();
|
|
var tokenData = JsonSerializer.Deserialize<JsonElement>(json);
|
|
|
|
CurrentChannel.AccessToken = tokenData.GetProperty("access_token").GetString()!;
|
|
CurrentChannel.TokenExpiry = DateTime.UtcNow.AddSeconds(tokenData.GetProperty("expires_in").GetInt32());
|
|
_sessionChanged?.Invoke(CurrentChannel);
|
|
return true;
|
|
}
|
|
|
|
private async Task<YouTubeChannel?> FetchChannelInfo(string accessToken, string refreshToken, int expiresIn)
|
|
{
|
|
_http.DefaultRequestHeaders.Authorization = new("Bearer", accessToken);
|
|
var response = await _http.GetAsync("https://www.googleapis.com/youtube/v3/channels?part=snippet&mine=true");
|
|
if (!response.IsSuccessStatusCode) return null;
|
|
|
|
var json = await response.Content.ReadAsStringAsync();
|
|
var data = JsonSerializer.Deserialize<JsonElement>(json);
|
|
var items = data.GetProperty("items");
|
|
|
|
if (items.GetArrayLength() == 0) return null;
|
|
|
|
var snippet = items[0].GetProperty("snippet");
|
|
CurrentChannel = new YouTubeChannel
|
|
{
|
|
ChannelId = items[0].GetProperty("id").GetString()!,
|
|
DisplayName = snippet.GetProperty("title").GetString()!,
|
|
ProfileImageUrl = snippet.GetProperty("thumbnails").GetProperty("default").GetProperty("url").GetString()!,
|
|
AccessToken = accessToken,
|
|
RefreshToken = refreshToken,
|
|
TokenExpiry = DateTime.UtcNow.AddSeconds(expiresIn)
|
|
};
|
|
|
|
_sessionChanged?.Invoke(CurrentChannel);
|
|
return CurrentChannel;
|
|
}
|
|
}
|