Files
LlamaCasty/ytLive.Tests/StreamRecoveryTests.cs
T
gramps 72cb3ad55a feat(stream): retry a dropped push instead of ending the session (TASK 32·1)
A dead encoder used to run the whole stop path, so a one-second blip ended the broadcast. Now a dropped
push is relaunched against the same ingest while the broadcast is still alive.

- `Services/StreamRetryPolicy.cs` — immediate, +1 s, +2 s, +3 s. Minimum waits on purpose (creator
  ruling): YouTube's grace is short, so every second not pushing is grace spent.
- `Services/StreamRecovery.cs` — the loop, with the audio pipe recreated before every attempt (its
  server is single-instance and unusable after the old client dies, so a naive relaunch fails on a
  missing input). After a push comes up it asks the API whether the broadcast survived: "complete"
  ends recovery as `BroadcastComplete` instead of showing a live sign over a dead stream; an API
  hiccup counts as recovered rather than ending a healthy session.
- `FramePump.EncoderFailed` — a dead push is recoverable; a compositor fault still goes through
  `Failed` and ends the session, because retrying it would loop.
- `MainViewModel.Recovery.cs` — wires the steps, reports each episode into the left panel alert stack
  (one row per episode, updated in place, log range painted), and cancels on Stop.
- Alert stack polish: a rule and a gap now separate the stack from the scene layers (they read as one
  list before), and the licence indicator uses the creator's wording — `STEAM ID NOT PRESENT` /
  `Steam ID Limit: 30fps` / `Click for More Info`, becoming `STEAM ID PRESENT` / `60fps` with a close
  control once owned.

Tests: `StreamRecoveryTests` (schedule, recover on attempt 2 with the pipe restarted each time,
complete-broadcast honesty, unknown liveness, give-up, cancel, audio-restart fault),
`FramePumpTests` now pin that process death raises `EncoderFailed` and not `Failed`.
FAST gate: 538 passed (one documented pre-existing audio failure), 0 warnings.
2026-11-05 12:09:38 -08:00

163 lines
5.9 KiB
C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Xunit;
using ytLive.Services;
namespace ytLive.Tests;
/// <summary>
/// TASK 32·1 — blip retry, exercised through <see cref="StreamRecovery"/> with fake steps: no ffmpeg,
/// no network, no waiting on the real schedule. The rules that matter: the first attempt is immediate,
/// the audio pipe is recreated before every push, a reconnect that lands on a COMPLETE broadcast is
/// reported honestly instead of pretending to be live, and giving up is a definite outcome, not a hang.
/// </summary>
public class StreamRecoveryTests
{
private static StreamRetryPolicy NoWaits(int attempts = 4)
=> new(Enumerable.Repeat(TimeSpan.Zero, attempts).ToArray());
[Fact]
public void DefaultPolicy_StartsImmediately_ThenOneTwoThreeSeconds()
{
var policy = StreamRetryPolicy.Default;
Assert.Equal(4, policy.Attempts);
Assert.Equal(TimeSpan.Zero, policy.WaitBefore(0));
Assert.Equal(TimeSpan.FromSeconds(1), policy.WaitBefore(1));
Assert.Equal(TimeSpan.FromSeconds(2), policy.WaitBefore(2));
Assert.Equal(TimeSpan.FromSeconds(3), policy.WaitBefore(3));
}
[Fact]
public async Task RecoversOnTheSecondAttempt_AndRestartsTheAudioPipeEachTime()
{
var pushes = 0;
var audioRestarts = 0;
var reported = new List<string>();
var recovery = new StreamRecovery(NoWaits(), new StreamRecoverySteps
{
RestartAudio = _ => { audioRestarts++; return Task.CompletedTask; },
StartPush = _ => Task.FromResult(++pushes > 1), // first start fails, second works
CheckBroadcast = _ => Task.FromResult(BroadcastLiveness.Live),
Report = reported.Add,
Log = _ => { },
});
var result = await recovery.RunAsync();
Assert.Equal(RecoveryOutcome.Recovered, result.Outcome);
Assert.Equal(2, result.Attempts);
Assert.Equal(2, pushes);
Assert.Equal(2, audioRestarts); // the pipe is unusable after the old client died
Assert.Contains(reported, text => text.Contains("reconnecting (attempt 1"));
Assert.Contains(reported, text => text.StartsWith("Stream recovered"));
}
[Fact]
public async Task ABroadcastThatAlreadyEnded_IsReportedAsComplete_NotAsRecovered()
{
var reported = new List<string>();
var recovery = new StreamRecovery(NoWaits(), new StreamRecoverySteps
{
RestartAudio = _ => Task.CompletedTask,
StartPush = _ => Task.FromResult(true),
CheckBroadcast = _ => Task.FromResult(BroadcastLiveness.Complete),
Report = reported.Add,
Log = _ => { },
});
var result = await recovery.RunAsync();
Assert.Equal(RecoveryOutcome.BroadcastComplete, result.Outcome);
Assert.Contains(reported, text => text.Contains("cannot be resumed"));
Assert.DoesNotContain(reported, text => text.StartsWith("Stream recovered"));
}
[Fact]
public async Task UnknownLiveness_CountsAsRecovered()
{
// If the API hiccups we cannot prove the broadcast is gone; treating that as failure would
// end sessions that are actually fine.
var recovery = new StreamRecovery(NoWaits(), new StreamRecoverySteps
{
RestartAudio = _ => Task.CompletedTask,
StartPush = _ => Task.FromResult(true),
CheckBroadcast = _ => Task.FromResult(BroadcastLiveness.Unknown),
Report = _ => { },
Log = _ => { },
});
Assert.Equal(RecoveryOutcome.Recovered, (await recovery.RunAsync()).Outcome);
}
[Fact]
public async Task EveryAttemptFailing_GivesUpWithTheCount()
{
var reported = new List<string>();
var recovery = new StreamRecovery(NoWaits(3), new StreamRecoverySteps
{
RestartAudio = _ => Task.CompletedTask,
StartPush = _ => Task.FromResult(false),
CheckBroadcast = _ => Task.FromResult(BroadcastLiveness.Live),
Report = reported.Add,
Log = _ => { },
});
var result = await recovery.RunAsync();
Assert.Equal(RecoveryOutcome.GaveUp, result.Outcome);
Assert.Equal(3, result.Attempts);
Assert.Contains(reported, text => text.Contains("off air"));
}
[Fact]
public async Task CancellingMidRecovery_StopsWithoutTouchingThePush()
{
using var cts = new CancellationTokenSource();
var pushes = 0;
var recovery = new StreamRecovery(StreamRetryPolicy.Default, new StreamRecoverySteps
{
RestartAudio = _ => Task.CompletedTask,
StartPush = _ => { pushes++; return Task.FromResult(false); },
CheckBroadcast = _ => Task.FromResult(BroadcastLiveness.Live),
Report = _ => { },
Log = _ => { },
Delay = (_, ct) => { cts.Cancel(); ct.ThrowIfCancellationRequested(); return Task.CompletedTask; },
});
var result = await recovery.RunAsync(cts.Token);
Assert.Equal(RecoveryOutcome.Cancelled, result.Outcome);
Assert.True(pushes <= 1, $"cancelling must stop the loop, but the push was started {pushes} times");
}
[Fact]
public async Task AAudioRestartFault_IsAnAttemptFailure_NotACrash()
{
var attempts = 0;
var recovery = new StreamRecovery(NoWaits(2), new StreamRecoverySteps
{
RestartAudio = _ =>
{
attempts++;
throw new InvalidOperationException("pipe busy");
},
StartPush = _ => Task.FromResult(true),
CheckBroadcast = _ => Task.FromResult(BroadcastLiveness.Live),
Report = _ => { },
Log = _ => { },
});
var result = await recovery.RunAsync();
Assert.Equal(RecoveryOutcome.GaveUp, result.Outcome);
Assert.Equal(2, attempts);
}
}