gramps
18ab553b0e
startup.log 2026-09-22 (via the user's run of the new build): every session
start logged 'Stream health poll failed: The requested operation requires an
element of type String, but the target element has type Object'.
Root cause: GetStreamHealthAsync did status.healthStatus.GetString(), but the
real API nests it as status.healthStatus = {status, lastUpdateTimeSeconds,
configurationIssues[]} — an OBJECT, per the liveStreams reference
https://developers.google.com/youtube/v3/live/docs/liveStreams (checked the
docs before fixing, per derivative-work rule). Our flat-string fixture was the
wrong assumption since TASK 9; the report-by-exception health banner had been
silently dead.
Fix: read the nested healthStatus.status + nested configurationIssues[], tolerating
the legacy flat-string shape so nothing else breaks. Tests flipped to the real
object shape (the Good Dog for this change). Full suite 315/315, build 0 warnings.
Also recorded in MyMistakes.md (API-shape recipe) and ai.md/Services index. End-of-session
transition(complete) 403 invalidTransition (enableAutoStop fallback) observed on all three
2026-09-22 stops — separate racy-design issue, carried, not in this change.
94 lines
6.2 KiB
Markdown
94 lines
6.2 KiB
Markdown
# HANDOFF — 2026-09-22 (TASK 42 committed; health-poll parse fix in flight)
|
|
|
|
## Branch / Commit State
|
|
|
|
`main` HEAD = **`e69db4d` — feat(ui): TASK 42 top bar redesign …** (committed).
|
|
Pushed state at `197ee81` (verified from the app-build the user ran after the commit). **Working
|
|
tree DIRTY — health-poll parse bug fix, one small change (code + tests + docs):**
|
|
|
|
```
|
|
M Services/YouTubeStreamService.cs (parse fix)
|
|
M ytLive.Tests/YouTubeStreamServiceTests.cs (fixtures flipped to REAL api shape)
|
|
M ai.md, Services/index.md, MyMistakes.md
|
|
M HANDOFF.md (this rewrite)
|
|
```
|
|
|
|
## What shipped — TASK 42: top bar redesign (2026-09-22)
|
|
|
|
Full record: **`TASKS/task-42-top-bar-redesign.md`**. Creator directive: "forget this one dog plan
|
|
bullshit. Our one plan is replacing the top menu bar with something usable." The old bar's six
|
|
widget grammars (sliding pills, dots, badges, buttons, hidden sign-in context menu, live-window
|
|
status) collapsed into **ONE surface rendered by the FIRST decision — Record or Stream**:
|
|
|
|
- **Mode switch:** one segmented **REC|ON-AIR** toggle (`SegmentToggle`/`SegmentLabel` styles).
|
|
Going back = one tap on the other segment. Runs idle-only; retires while running.
|
|
- **Record world:** switch + **Start Recording** — no YouTube identity at all.
|
|
- **Stream world:** switch + **Go Live** + Test + account zone (Sign In until connected; then the
|
|
avatar, right-click Change Account/Logout). **Test is a child of Stream** — procs only ON-AIR-armed
|
|
AND signed-in (`ShowTestButton`/`CanStartTest`).
|
|
- **Running:** one reality line `● REC|LIVE|TEST 00:12:34` (green/red/gold `RunningDotBrush`) + End.
|
|
- **Gear** moved up from bottom bar, ~3 wordmark letters past the brand, one click = Settings / Bug /
|
|
Feature / About menu (`GearButton_Click`). Bottom-bar gear removed. Task 40 Unit B is DONE by this.
|
|
- **Sign-in = the account-confirm step:** no Google API enumerates machine accounts; OAuth is
|
|
single-account, so Switch Account re-runs the chooser (`login_hint`+`select_account`) — login and
|
|
account-confirmation are one surface. Existing `ChangeAccountCommand`/`LogoutCommand` resurface via
|
|
the avatar.
|
|
- **PRIVATE/TEST chips gone from the bar** (dev-phase forced-private becomes an OPTION at ship).
|
|
|
|
**Good Dog** — `ytLive.Tests/TopBarModeTests.cs` (one `[Fact]`, `RealAppHost.Run`): default record
|
|
world → arm ON-AIR → sign-in/avatar/Test gating flips → one-tap flip back → direct stream status
|
|
changing + running reality values. Also folded in: TASK 41's latent **Test pipeline bug fix** —
|
|
`BeginTestStream` now arms `OnAirPillOn` explicitly (unarmed → encoder booted with zero outputs →
|
|
"At least one output is required" → forced stop cascade). The TestStreamTests gate updated to match.
|
|
|
|
## In flight — health-poll parse fix (2026-09-22, from startup.log)
|
|
|
|
The user ran the new build and the app's `startup.log` showed `Stream health poll failed: The
|
|
requested operation requires an element of type 'String', but the target element has type 'Object'.`
|
|
on EVERY session start (2/2 test sessions). Root cause: `YouTubeStreamService.GetStreamHealthAsync`
|
|
called `healthStatus.GetString()` but the real API nests `status.healthStatus = {status,
|
|
lastUpdateTimeSeconds, configurationIssues[]}` — an OBJECT, not a string (docs:
|
|
https://developers.google.com/youtube/v3/live/docs/liveStreams). Our own flat-string fixture was the
|
|
wrong assumption from day one; the report-by-exception health banner had been silently dead. Fix in
|
|
the dirty tree reads the nested `.status` and nested `configurationIssues[]`, tolerating the old flat
|
|
shape; fixtures flipped to the real shape (the Good Dog). ALSO logged: end-of-session
|
|
`transition(complete)` 403 `invalidTransition` → enableAutoStop fallback hit all three 2026-09-22
|
|
stops (17:09 crash + both tests) — known racy design (transition AFTER encoder EOF), NOT in this fix's
|
|
scope, carried.
|
|
|
|
## ⚠️ Around the task
|
|
|
|
- **Full-suite run today: 314/315** — the one abort is the pre-existing
|
|
`LayerReorderPersistenceTests.RealMouseDrag_OnTheLayerList_PersistsTheReorder`, which injects
|
|
REAL physical mouse input (`SetCursorPos` + `mouse_event`, see its own docstring) and no-ops while
|
|
another window interferes. Cause observed 2026-09-22: **Path of Exile 2 + NVIDIA Overlay were
|
|
running** (fullscreen-game window hides the test window's rows; the drag never lands → reorder
|
|
assert fails). Close the game before running that test; it is unrelated to TASK 42 and has passed
|
|
on clean reruns previously.
|
|
- **Manual verification owed** (needs a real run on Windows): the app is a new build number when
|
|
next launched — check the new one-surface bar (switch ↔ worlds, gear menu, reality line).
|
|
- The app may be **RUNNING** — an in-place build fails MSB3021/MSB3027 until closed (temp-OutDir
|
|
workaround in ai.md). Close it before the manual pass.
|
|
- Full-suite note: the pre-existing real-camera startup flake did **not** occur in the 315/315 run.
|
|
- Test-env trap (recorded in the TASK): a dev machine's saved OAuth session loads synchronously and
|
|
makes `IsConnected` come back true in the VM ctor — signed-in-world tests must force
|
|
`vm.IsConnected = false/true` explicitly.
|
|
- `subscriberCount` rounded to 3 sig figs (YPP); carried. YPP slice 2 needs re-consent — do NOT
|
|
merge with other units.
|
|
- Polar product `d105dfa1…` still `$99/yr` — must become one-time before launch (carried).
|
|
`MARCOM.md`/`MONETIZATION.md` gitignored — never commit.
|
|
|
|
## Next step
|
|
|
|
Scope-check the declared list → build (0 warnings) → full test suite rerun → **one commit** for
|
|
TASK 42 (docs + code same change). Push only on the user's say-so. Then **TASK 40 App Settings
|
|
round** is queued (`TASKS/task-40-app-settings-round.md`) — units **A (camera) → C (defaults) → D
|
|
(accent)** remain (B/gear shipped early); Unit A's SharedReadOnly control-write question is the one
|
|
genuinely uncertain technical point — run its mitigation ladder before a third guess.
|
|
|
|
## Critical working rules (unchanged, still binding)
|
|
|
|
- **Good Dog = ONE integration test per change.**
|
|
- **Scope lock:** declare the file list before editing; `./scripts/scope-check.sh` before commit.
|
|
- WSL builds use the Windows dotnet host (`/mnt/c/Program Files/dotnet/dotnet.exe`, quoted paths).
|
|
- One runtime model, no model switching, no compaction summaries (user directive). |