gramps
7bb1207fb2
TASK 64 slice F — the two things left after the feature worked by hand. - App Settings → **Video clips → Auto Green/Blue Screen** (off by default). When on, a high-confidence detected screen is keyed as soon as the clip is added; the panel says "Removed automatically" so an automatic change is never silent. Medium confidence still asks, low says nothing — a wrong automatic key eats the picture. - **A clip is a clip:** the alert box's own replacement clip keys through the same settings block (one alert box per layout, so its settings are the ones the next alert uses), and choosing an alert clip runs the same detector. The Green/Blue Screen panel now appears for a video layer *or* an alert box with a custom clip (`Source.ShowsChromaKey`). - Spill ships as the creator-facing **Fringe** switch; nothing further to tune behind it. Test: `ChromaKeyApplyTests` gains the auto-apply case (no click, still explicit in the panel) and an alert-clip case (its pipe asks ffmpeg for colorkey+despill with the blue screen type). Docs: TASK 64 complete in TASKS.md, known limits recorded in the task file, HANDOFF rewritten. verify.sh: 546 passed, 0 failed, 0 warnings.
32 lines
1.9 KiB
Markdown
32 lines
1.9 KiB
Markdown
# HANDOFF — 2026-11-05 (TASK 64 — green/blue screen for clips)
|
||
|
||
## State
|
||
|
||
- `main`. TASK 21 complete (video file layer + its soundtrack). TASK 64 shipped through slice E:
|
||
a clip with a green or blue backdrop is **offered** a key on add ("Looks like a green screen —
|
||
Remove it"), accepting it keys the background **inside the decode pipe** (bundled ffmpeg
|
||
`colorkey`/`despill`), with Amount/Softness/Fringe in the panel and the settings persisted.
|
||
Sessions are keyed by **path + look**, so identical looks share one decoder.
|
||
- Detection stays silent on lawns/pitches (confidence = coverage × hue tightness) and ignores
|
||
letterbox bars. It never acts on its own.
|
||
- Slice F shipped too: **App Settings → Video clips → "Auto Green/Blue Screen"** (off by default,
|
||
high confidence only, and the panel states when a key was automatic) and **alert clips** key through
|
||
the same settings block (one alert box per layout).
|
||
- Tests: `ChromaKeyDetectorTests` + `ChromaKeyApplyTests` (pipe asks ffmpeg to key; offer → accept →
|
||
keyed session feeds the resolver; survives save; auto-apply; alert clip keyed). App build 0 warnings.
|
||
|
||
## Next action
|
||
|
||
- TASK 64 is complete. Next queued: TASK 49 (chat profanity filter). Day 3's TASK 32/33 resilience slices remain outstanding —
|
||
32·4 (fragmented MP4) is the smallest.
|
||
- Do not push absent a checkpoint request.
|
||
|
||
## Landmines
|
||
|
||
- `LayerReorderPersistenceTests.RealMouseDrag_OnTheLayerList_PersistsTheReorder` injects physical
|
||
mouse input. Do not run it while the desktop is in use.
|
||
- Integration tests constructing `MainWindow` must set a temporary `LayoutPathOverride` and clear it in `finally`.
|
||
- Media sessions are keyed by **path + look** (`MainViewModel.MediaSessionKey`); never acquire by raw
|
||
path, and release through `ReleaseMediaIfUnused`.
|
||
- Bundled FFmpeg stays outside the single-file exe (`ExcludeFromSingleFile="true"`).
|