Files
LlamaCasty/HANDOFF.md
T
gramps 9b56e88800 Revert ab29ec8: container==content auto-fit made it worse — back to alpha-crop with the container at element size
The container tracks the element's own Width/Height again; the crop stays in the bitmap.
2026-08-28 12:09:13 -07:00

4.1 KiB
Raw Blame History

HANDOFF — Session State

Branch / Commit State

main, dirty working tree being committed as one unit (web source rendering fix — user-confirmed working). NOT pushed — user rule: never push without explicit instruction (2026-08-24). No feature branches pre-1.0: all work lands on main per work unit.

The web-source rendering work (2026-08-28) — CURRENT MODEL: canvas-size viewport + ALPHA-BBOX crop

History of failures (see MyMistakes.md for the full log): box-size rendering clipped full-bleed widgets to their upper-left chunk (fixed — page renders at the master canvas 1920×1080, stable, the one render the creator confirmed solid). Then four crop attempts failed in different ways: (1) the JSON.stringify return double-encoded under ExecuteScriptAsync, silently disabling the crop; (2) scrollWidth/scrollHeight at canvas size returns the whole viewport for full-canvas wrapper bodies → no trim (ghost boundary); (3) union-of-DOM-elements measured an unsettled layout on NavigationCompleted and BROKE the image (creator's "don't break the rendering" boundary crossed). (4) Reverting to f39ebd9's scroll-crop was another dead end (#2 again).

The CURRENT MODEL (this commit):

  • Services/WebView2Manager.cs — page renders at 1920×1080 (stable, never tracked); overflow:hidden
    • transparent-bg injection. FindContentBounds scans the Bgra32 capture per frame and crops to the bounding box of NON-TRANSPARENT pixels — the widget's true rendered extent, measured from the frame itself. No DOM query, no layout timing: it can never truncate visible content (worst case = full frame = the confirmed-good image). Stretch="Fill" maps the cropped frame flush under the selection box → the box hugs the widget on all four sides. QueryContentBoundsAsync + the JS script are DELETED.
  • MainWindow.xaml — web <Image> Stretch set to Fill via the IsWebSource DataTrigger (unchanged).
  • Invariant: render at canvas size; crop to the alpha extent; Fill to the box.
  • Unit tests: 3 new for FindContentBounds (tight box, no-alpha no-crop, full-alpha no-crop).

Property panel / sliders (2026-08-28): web URI ✕ clears the textbox; web ✓/✕ icon buttons IsTabStop="False" so Tab walks X→Y→W→H→URI; Slider style IsMoveToPointEnabled="True" restores click-anywhere-on-bar. All three confirmed fixed by the creator.

Build: 0 warnings; tests 7/7 (WebView2Manager). Rejected for the record: box-sized viewport (upper-left truncation), fixed 1920×1080 + Uniform (letterbox dead space), CSS margin/100% reset (enlarged gap), viewport==box (reflow/truncation/scrollbars), DOM-union crop (broke the image).

Key facts / landmines

  • App running locks ytLive.exe → build fails MSB3027 until creator exits the app.
  • Startup diagnostics: unhandled exceptions + checkpoints go to %APPDATA%\ytLlive\startup.log (Helpers/AppLog.cs). On a silent startup crash, read that.
  • Pre-existing test failures (unrelated to web source, do not chase): AudioPipelineTests.Mix_HonorsProviderGains_AndGameMute_KillsTheLoopback + RoundClipInteractionTests.Round_Clip_Corner_Is_Grabbable_And_Shape_Is_Circle.
  • Real-MainWindow tests MUST set LayoutPathOverride — DB pollution wiped real data once.
  • Good Dog Rule: ONE integration test per change; no new feature branches pre-1.0.
  • Scope Lock: declare the file list, run scripts/scope-check.sh before every commit.
  • Every feature change ships memory updates in the SAME commit — TASKS.md status + this file.
  • No CODING.md; conventions live in AGENTS.md + ai.md.

Next steps

  1. AWAIT creator's verdict on the ALPHA-BBOX crop — reload a widget URL at several box sizes; the selection frame must snap flush to the widget with no dead space, image must stay identical for full-bleed widgets. If an animated widget causes visible jitter, add crop hysteresis as a follow-up.
  2. Follow-up only if the creator asks: graceful handling of navigation errors / invalid URIs (TASK 17 ×9).
  3. Continue queue: TASK 18 local recording, TASK 21 media source, TASK 22 audio sync offset.