54 lines
3.5 KiB
Markdown
54 lines
3.5 KiB
Markdown
# HANDOFF — Session State
|
||
|
||
## Branch / Commit State
|
||
|
||
**`main`**, dirty working tree being committed as one unit (web source rendering fix — user-confirmed
|
||
working). **NOT pushed — user rule: never push without explicit instruction (2026-08-24).** No feature
|
||
branches pre-1.0: all work lands on `main` per work unit.
|
||
|
||
## The web-source rendering work (2026-08-28) — CURRENT MODEL: stable viewport + content-bounds crop
|
||
|
||
**Background:** viewport==box made dragging the box reflow the page (truncation, scrollbars,
|
||
unrecoverable image, "janky at stressful geometries"). Fixed-viewport + `Uniform` left letterbox
|
||
dead space. CSS reset enlarged the gap. Scrollbars were called "super fail". The right/bottom
|
||
dead-space + "not anchored at (0,0)" report persisted across every model — dead space was
|
||
page-internal (widget content smaller than the viewport), which is now cropped out.
|
||
|
||
**The model that satisfies invariants (implemented, visual verification pending):**
|
||
- `Services/WebView2Manager.cs` — stable viewport = the element's size at `Register` (snapshot,
|
||
never tracked → no reflow/truncation during resize). `overflow:hidden` (html+body) +
|
||
transparent-bg injection on every nav (nothing else). After each navigation,
|
||
`QueryContentBoundsAsync` reads the page's real content rect
|
||
(`scrollWidth/scrollHeight` vs `innerWidth/innerHeight` via `ExecuteScriptAsync` + JSON) and
|
||
`CaptureFrame` **crops the capture to the actual content bounds, anchored at (0,0)** — dead
|
||
space inside the viewport no longer reaches the box. Immediate capture on `NavigationCompleted`.
|
||
- `MainWindow.xaml` — web `<Image>` uses `Stretch="Fill"`: the cropped frame maps edge-to-edge,
|
||
so the selection box always bounds the real widget. `FramePump` unchanged.
|
||
- Invariants: **page viewport stable; display Fill-crops to content and fills the box.**
|
||
|
||
**Property panel / sliders (2026-08-28):** web URI ✕ clears the textbox; web ✓/✕ icon buttons
|
||
`IsTabStop="False"` so Tab walks X→Y→W→H→URI; Slider style `IsMoveToPointEnabled="True"`
|
||
restores click-anywhere-on-bar.
|
||
|
||
Build: 0 warnings; tests 4/4. Rejected for the record: fixed 1920×1080+`Uniform` (letterbox),
|
||
CSS margin/100% reset (enlarged gap), viewport==box (reflow/truncation/scrollbars).
|
||
|
||
## Key facts / landmines
|
||
|
||
- **App running locks `ytLive.exe`** → build fails MSB3027 until creator exits the app.
|
||
- **Startup diagnostics:** unhandled exceptions + checkpoints go to `%APPDATA%\ytLlive\startup.log`
|
||
(`Helpers/AppLog.cs`). On a silent startup crash, read that.
|
||
- **Pre-existing test failures (unrelated to web source, do not chase):**
|
||
`AudioPipelineTests.Mix_HonorsProviderGains_AndGameMute_KillsTheLoopback` +
|
||
`RoundClipInteractionTests.Round_Clip_Corner_Is_Grabbable_And_Shape_Is_Circle`.
|
||
- **Real-MainWindow tests MUST set `LayoutPathOverride`** — DB pollution wiped real data once.
|
||
- **Good Dog Rule:** ONE integration test per change; no new feature branches pre-1.0.
|
||
- **Scope Lock:** declare the file list, run `scripts/scope-check.sh` before every commit.
|
||
- **Every feature change ships memory updates in the SAME commit** — `TASKS.md` status + this file.
|
||
- No `CODING.md`; conventions live in `AGENTS.md` + `ai.md`.
|
||
|
||
## Next steps
|
||
1. AWAIT creator's verdict on viewport==box (geometry-agnostic) rendering — visual check with a
|
||
widget URL at several box sizes; the selection frame must snap flush with no padding.
|
||
2. Follow-up only if the creator asks: graceful handling of navigation errors / invalid URIs (TASK 17 ×9).
|
||
3. Continue queue: TASK 18 local recording, TASK 21 media source, TASK 22 audio sync offset. |